Skip site navigation (1) Skip section navigation (2)

Re: [gpoo@ubiobio.cl: Re: [HACKERS] EXPLAIN omits schema?]

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [gpoo@ubiobio.cl: Re: [HACKERS] EXPLAIN omits schema?]
Date: 2007-06-20 15:32:29
Message-ID: 18370.1182353549@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> I am forwarding it to improve the chances of it being delivered ...  The
> patch in the fwd is not a nice MIME part but it should work without
> problem anyway.

I'm not sure why anyone would want *both* xml and regular output
produced at once.  The patch's treatment of name quoting seems both
inconsistent and highly unlikely to be correct (how does XML deal
with embedded quotes in attribute values, anyway?).  The submitter
appears to have no clue about the maintenance details required when
adding a field to a Node struct.

But the big question is: where's the DTD?  Has he even tried to design
a sane XML representation, or just emitted whatever was convenient given
the existing code structure?  I'm fairly suspicious that a patch that
doesn't rearrange the existing code at all is probably not producing
the ideal XML structure.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-06-20 15:43:06
Subject: Re: Preliminary GSSAPI Patches
Previous:From: Heikki LinnakangasDate: 2007-06-20 13:47:31
Subject: Load Distributed Checkpoints, take 3

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group