Re: pgbench not setting scale size correctly?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Smith <gsmith(at)gregsmith(dot)com>
Cc: "pgsql-general(at)postgresql(dot)org General" <pgsql-general(at)postgresql(dot)org>
Subject: Re: pgbench not setting scale size correctly?
Date: 2008-03-14 15:49:48
Message-ID: 18343.1205509788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-patches

Greg Smith <gsmith(at)gregsmith(dot)com> writes:
> On Fri, 14 Mar 2008, Tom Lane wrote:
>> Yeah, -s is only meaningful when given with -i. Maybe someday we ought
>> to fix pgbench to complain if you try to set it at other times.

> You have to pass -s in to the actual run if you're specifying your own
> custom script(s) using -f and you want the :scale variable to be defined.

Right, I knew that at one time ;-)

> The way the option parsing code is done would make complaining in the case
> where your parameter is ignored a bit of a contortion. The part that
> detects based on the database is after all the other parsing because the
> connection has to be brought up first.

Yeah. But couldn't we have that part issue a warning if -s had been set
on the command line?

regards, tom lane

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Erik Jones 2008-03-14 15:56:39 Re: Trigger to run @ connection time?
Previous Message Steve Crawford 2008-03-14 15:43:26 Re: postgre vs MySQL

Browse pgsql-patches by date

  From Date Subject
Next Message Justin 2008-03-14 17:10:21 Re: pgbench not setting scale size correctly?
Previous Message Jeremy Drake 2008-03-14 15:40:30 Re: Suppress compiler warnings on mingw