Skip site navigation (1) Skip section navigation (2)

Re: Cleanup of ODBC

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL odbc list <pgsql-odbc(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Cleanup of ODBC
Date: 2001-03-28 16:06:26
Message-ID: 18261.985795586@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-odbcpgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> I am working to clean up the comments in ODBC, and remove some blank
> lines that make no sense being there.  This will not affect the code in
> any way.  I should commit in a few hours.

Is it really appropriate to be doing this sort of work post-RC1?
I see no gain and a nontrivial risk that you will break something
without knowing it (and without providing adequate time to test it).

It's bad enough to be running pgindent at this late stage of the cycle,
but at least pgindent is automated and relatively unlikely to make
errors.  Massive hand edits are another story.

In short: save it for 7.2.

			regards, tom lane

In response to

Responses

pgsql-odbc by date

Next:From: Bruce MomjianDate: 2001-03-28 16:07:22
Subject: Re: Cleanup of ODBC
Previous:From: Bruce MomjianDate: 2001-03-28 15:25:54
Subject: Cleanup of ODBC

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-03-28 16:07:22
Subject: Re: Cleanup of ODBC
Previous:From: Bruce MomjianDate: 2001-03-28 15:25:54
Subject: Cleanup of ODBC

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group