Skip site navigation (1) Skip section navigation (2)

Re: fix windows contrib compile warnings for redefined macros

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix windows contrib compile warnings for redefined macros
Date: 2004-10-21 18:04:42
Message-ID: 18114.1098381882@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> This patch fixes contrib so that it compiles under windows without 
> warnings about redefines for min, max, V_UNKNOWN and IDIGNORE

Surely this is wrong.  You might be able to assume that Windows'
definitions for min/max are the same as what this code is expecting,
but it's a lot bigger stretch to assume that for the other ones.
(Does tsearch2 still *work* after you change it this way??)

The right thing for the min/max macros is to get rid of them anyway,
and use the Min/Max macros from c.h.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2004-10-21 18:39:42
Subject: Re: fix windows contrib compile warnings for redefined
Previous:From: Andrew DunstanDate: 2004-10-21 17:36:44
Subject: fix windows contrib compile warnings for redefined macros

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group