Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c'

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Vadim Mikheev <vadim(at)krs(dot)ru>
Cc: PostgreSQL Developers List <hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c'
Date: 1999-05-29 15:03:04
Message-ID: 18094.927990184@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Vadim Mikheev <vadim(at)krs(dot)ru> writes:
>> bufmgr.c
>> Log Message:
>> Missing semicolons in non-HAS_TEST_AND_SET code paths :-(

> Thanks, Tom!
> I must say that I never tested non-Has_TEST_AND_SET case.

I haven't either --- but those two places stuck out like sore thumbs
after the pgindent run...

This suggests that none of the beta-testing group uses a machine that
doesn't have TEST_AND_SET support.  I suppose that's good news about the
coverage of s_lock.h, but it makes me worry that the non-TEST_AND_SET
code hasn't even been compiled, let alone exercised.  Someone ought to
build and test a copy with TEST_AND_SET deliberately removed from the
port.h file.

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 1999-05-29 15:28:34
Subject: Re: [HACKERS] Open 6.5 items
Previous:From: D'Arcy J.M. CainDate: 1999-05-29 12:07:42
Subject: Re: [HACKERS] Open 6.5 items

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group