Re: fork/exec patch: pre-CreateProcess finalization

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jan Wieck <JanWieck(at)Yahoo(dot)com>
Cc: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, "'Bruce Momjian '" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "''pgsql-patches(at)postgresql(dot)org' '" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fork/exec patch: pre-CreateProcess finalization
Date: 2004-01-09 00:24:04
Message-ID: 18016.1073607844@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Jan Wieck <JanWieck(at)Yahoo(dot)com> writes:
> Something after 2003/11/20 enhanced the query cancel handling. Namely,
> CVS tip now responds to a query cancel with a postmaster restart
> canceling all queries. Could the fork/exec stuff be responsible for this?

Whoever changed this:

status = ProcessStartupPacket(port, false);

if (status != STATUS_OK)
return 0; /* cancel request processed, or error */

to this:

status = ProcessStartupPacket(port, false);

if (status != STATUS_OK)
{
ereport(LOG,
(errmsg("connection startup failed")));
proc_exit(status);
}

is responsible. May we have an explanation of the thought process,
if any?

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Claudio Natoli 2004-01-09 00:41:22 Re: Win32 signal code - first try
Previous Message Claudio Natoli 2004-01-09 00:18:37 Re: Win32 signal code - first try

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-01-09 00:41:32 Re: fork/exec patch: pre-CreateProcess finalization
Previous Message Claudio Natoli 2004-01-09 00:18:37 Re: Win32 signal code - first try