Skip site navigation (1) Skip section navigation (2)

Re: clang's static checker report.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl>
Cc: Greg Stark <gsstark(at)mit(dot)edu>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alex Hunsaker <badalex(at)gmail(dot)com>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: clang's static checker report.
Date: 2009-08-30 18:14:00
Message-ID: 17988.1251656040@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> writes:
> please don't tell me that this is bogus: http://zlew.org/postgresql_static_check/scan-build-2009-08-30-4/report-7JaICX.html#EndPath 

Yes, it's bogus.  ctid is never passed as NULL.  It might point at
an "invalid" itempointer (one with ip_posid == 0).  Look at the only
call site.

This seems to indicate that clang is stupider than I would have hoped.
Isn't it capable of doing the same types of analysis that gcc does
when inlining?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Grzegorz JaskiewiczDate: 2009-08-30 18:28:21
Subject: Re: clang's static checker report.
Previous:From: Stefan KaltenbrunnerDate: 2009-08-30 18:01:36
Subject: Re: LWLock Queue Jumping

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group