Skip site navigation (1) Skip section navigation (2)

Re: GIN, partial matches, lossy bitmaps

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GIN, partial matches, lossy bitmaps
Date: 2009-03-05 23:35:24
Message-ID: 17706.1236296124@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
> Changes since 28.2 
> (http://archives.postgresql.org/message-id/499B0FFA.8040608@sigaev.ru)

> - fixes/changes pointed by Robert 
> (http://archives.postgresql.org/pgsql-hackers/2009-02/msg00987.php)
> - gingetbitmap will never throw error about lossiness of bitmap, it will return 
> lossy bitmap even it was a prefix search.
> - remove tbm_check_tuple/tbm_has_lossy/tbm_max_non_lossy methods because they 
> become unused
> - add new method tbm_add_page(TIDBitmap*, BlockNumber) to add the whole page to 
> the TIDBitmap.

I cleaned up and applied the planner part of this, since that seems
reasonably useful in its own right for experimental index AMs,
regardless of where we settle out for GIN.  (The "cleanup" mostly
consisted of fixing it to not make extra calls to find_usable_indexes
--- that's an expensive function, and there's no very good reason to
run it another time rather than separating out the indexes afterwards.)

Attached is the remainder of the patch with relatively minor fixes.
The main change I made is to get rid of the changes in gincostestimate;
I agree with Robert that it's probably inappropriate to consider the
current pending-list size during planning.  I haven't really reviewed
any of the rest of it; this is just to have a clean patch against HEAD.

			regards, tom lane


Attachment: fast_insert_gin-0.30.gz
Description: application/octet-stream (22.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Josh BerkusDate: 2009-03-06 01:08:02
Subject: Can we drop ABSTIME?
Previous:From: Bernd HelmleDate: 2009-03-05 23:32:40
Subject: Re: Validating problem in the isn contrib module

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group