From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
Cc:
sfrost(at)snowman(dot)net, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>,
Markus Wanner <markus(at)bluegap(dot)ch>, Alex Hunsaker <badalex(at)gmail(dot)com>,
PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: New patch for Column-level privileges
Date:
2009-01-13 04:16:28
Message-ID:
17692.1231820188@sss.pgh.pa.us (view raw or flat )
Thread:
2009-01-02 23:11:21 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-03 21:28:43 from "Alex Hunsaker" <badalex(at)gmail(dot)com>
2009-01-03 21:35:38 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-04 14:14:02 from Markus Wanner <markus(at)bluegap(dot)ch>
2009-01-04 16:18:34 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-04 17:29:45 from Markus Wanner <markus(at)bluegap(dot)ch>
2009-01-04 17:49:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-07 02:43:24 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-07 06:46:03 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-07 09:18:35 from Markus Wanner <markus(at)bluegap(dot)ch>
2009-01-07 09:27:47 from KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
2009-01-07 14:16:30 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-08 00:58:00 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-08 02:13:58 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-08 05:41:38 from "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>
2009-01-08 06:41:08 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-08 12:58:44 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-08 20:34:51 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-08 20:41:22 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-08 23:29:41 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-09 00:12:01 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-09 03:00:18 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-09 04:34:44 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-09 05:59:07 from "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>
2009-01-09 17:15:11 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-09 21:28:18 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-10 05:22:44 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-10 19:14:32 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-13 01:58:16 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-13 03:54:12 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-13 04:16:28 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-13 05:59:07 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-13 08:54:09 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-13 14:21:21 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-13 15:11:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-14 03:45:59 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-14 18:43:06 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-15 02:24:48 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-15 03:36:52 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-15 05:33:55 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-15 15:07:42 from "Jaime Casanova" <jcasanov(at)systemguards(dot)com(dot)ec>
2009-01-15 16:22:06 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-13 14:01:22 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-13 15:23:16 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-13 16:48:36 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-13 16:57:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-13 17:23:41 from Stephen Frost <sfrost(at)snowman(dot)net>
2009-01-13 17:33:30 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-14 02:54:59 from KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
2009-01-14 03:14:53 from Stephen Frost <sfrost(at)snowman(dot)net>
Lists:
pgsql-hackers
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> writes:
> I reconsidered the previous walker implementation independent
> from other parser codes is more simple and better.
And slower, and equally subject to this bug, so I'm not convinced.
> Stephen, Tom, what is your opinion?
I'm thinking make_var is not the place to do this. The places that are
supposed to be taking care of permissions are the ones that do this:
/* Require read access --- see comments in setTargetTable() */
rte->requiredPerms |= ACL_SELECT;
It's possible that we've missed some --- in particular, right at the
moment I am not sure that whole-row Vars are handled properly.
And maybe we could refactor a little bit to save some code.
But those are basically the same places that ought to be adding
bits to the column bitmaps.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Koichi SuzukiDate: 2009-01-13 04:21:21Subject : Re: Documenting pglesslogPrevious :From : Robert HaasDate : 2009-01-13 04:14:01Subject : Re: Recovery Test Framework
