Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Date: 2010-09-28 06:36:24
Message-ID: 17539.1285655784@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes:
> Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.

This patch appears incorrect to me.  Only the DISCARD ALL variant is
prohibited inside BEGIN, so why is it making all variants of DISCARD
autocommittable?

The DROP coding immediately above is a model for how to deal with
two-word commands.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Itagaki TakahiroDate: 2010-09-28 06:45:09
Subject: Re: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.
Previous:From: Itagaki TakahiroDate: 2010-09-28 05:30:49
Subject: pgsql: Add DISCARD to the command_no_begin list for AUTOCOMMIT=off.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group