Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Date: 2012-04-18 02:53:44
Message-ID: 17423.1334717624@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> You know, I could have sworn it was discussed, but when I look back I 
> see it wasn't. I must have been remembering the recent logging protocol bug.

> I'll revert it if people want, although I still think it's a bug.

I think we discussed it to the extent of agreeing it was a bug, but
the question of whether to back-patch was not brought up.

I can see both sides of this.  I agree that the old behavior is buggy,
but what I imagine Robert is worried about is scripts that accidentally
work okay today and would stop working once the PG programs are fixed
to complain about bogus usage.  People tend not to like it if you make
that kind of change in a minor release.  Against that you have to set
the probability of mistaken interactive usage being caught, or not,
by a repaired program.  Stopping a disastrous command-line typo seems
potentially worth any pain from having to fix scripts that would have
to be fixed eventually anyway.

If you had patched only HEAD I would have been fine with that, but
seeing that you've done the work to back-patch I'm kind of inclined
to let it stand.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Greg Sabino MullaneDate: 2012-04-18 03:07:58
Subject: Re: Bug tracker tool we need
Previous:From: Tom LaneDate: 2012-04-18 02:30:24
Subject: Re: Bug tracker tool we need

pgsql-committers by date

Next:From: Robert HaasDate: 2012-04-18 03:22:56
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen
Previous:From: Andrew DunstanDate: 2012-04-17 23:38:34
Subject: Re: Re: [COMMITTERS] pgsql: Don't override arguments set via options with positional argumen

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group