Skip site navigation (1) Skip section navigation (2)

Re: pgsql: get_names_for_var didn't do recursion for

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>,pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: get_names_for_var didn't do recursion for
Date: 2005-01-13 22:55:56
Message-ID: 17413.1105656956@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
>> get_names_for_var didn't do recursion for unnamed JOIN vars quite right;
>> got it wrong when the JOIN was in an outer query level.  Per example from
>> Laurie Burrow.  Also fix same issue in markTargetListOrigin.  I think the
>> latter is only a latent bug since we currently don't apply 
>> markTargetListOrigin
>> except at the outer level ... but should do it right anyway.

> BTW, this code is almost verbatim in 7.4.  Do you want me to patch it
> back?

In markTargetListOrigin you mean?  I think it's unnecessary, but if
you want to...

			regards, tom lane

In response to

pgsql-committers by date

Next:From: Tom LaneDate: 2005-01-13 23:08:02
Subject: pgsql: Change exec_eval_simple_expr's param list allocation call from
Previous:From: Alvaro HerreraDate: 2005-01-13 22:44:36
Subject: Re: pgsql: get_names_for_var didn't do recursion for

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group