Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Fix (some of the) breakage introduced into query-cancel

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel
Date: 2010-01-07 21:12:38
Message-ID: 17312.1262898758@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Ah, you were referring to those lines. I thought you were referring to
> the additional lines you put in around ClientAuthInProgress.

That's not really additional code --- I was just moving (and duplicating
:-() some of the steps so that they wouldn't get executed if we choose
to fall out without processing the query cancel request.  The previous
logic here was essentially to prevent ProcessInterrupts from being
called at all while DoingCommandRead.  The new logic is to call it and
have it understand that it shouldn't do anything if DoingCommandRead
(except when the HS state indicates an override).

			regards, tom lane

In response to

pgsql-committers by date

Next:From: Takahiro ItagakiDate: 2010-01-08 00:38:20
Subject: pgsql: Add buffer access counters to pg_stat_statements.
Previous:From: Simon RiggsDate: 2010-01-07 20:46:49
Subject: Re: pgsql: Fix (some of the) breakage introduced into query-cancel

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group