Re: [HACKERS] Patch to fix plpython on OS X

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Fuhr <mike(at)fuhr(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, "Jim C(dot) Nasby" <decibel(at)decibel(dot)org>, pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch to fix plpython on OS X
Date: 2005-07-24 02:38:59
Message-ID: 17312.1122172739@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Michael Fuhr <mike(at)fuhr(dot)org> writes:
>> Tom Lane wrote:
>>> Hmm ... if it's *not* a version thing then I really do want to know
>>> what's causing it. Anyone have an idea why this machine is saying
>>> '\u80' where everyone else's python says u'\x80' ?

> The regression tests that are failing are from the patch I submitted
> about a month ago to fix a core dump in PL/Python:

> http://archives.postgresql.org/pgsql-patches/2005-06/msg00519.php

> The tests exercise the error checking that the patch added, doing
> things that previously caused a segmentation fault but that now
> raise an exception. Should those tests remain in place? If so,
> should we rewrite them to avoid the version-specific Python messages
> (possibly by wrapping them in a PL/pgSQL function that traps the
> errors), or should we just leave the tests alone now that we think
> we understand what's happening?

Well, if it is just a Python version issue then all we need do is add
a variant expected-output file to match. I was just expressing a
desire to know that for sure before we wallpaper over the symptom...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2005-07-24 08:57:17 Re: Constraint Exclusion on all tables
Previous Message Michael Fuhr 2005-07-24 02:34:33 Re: [HACKERS] Patch to fix plpython on OS X

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-07-24 04:37:08 Re: fix integer datetime division rounding error
Previous Message Michael Fuhr 2005-07-24 02:34:33 Re: [HACKERS] Patch to fix plpython on OS X