| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump end comment |
| Date: | 2004-03-30 14:26:13 |
| Message-ID: | 1730.1080656773@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> On Tue, 30 Mar 2004, Bruce Momjian wrote:
>> I like an end-of-dump marker for folks who want to check if the dump got
>> truncated somehow. I can see how to do that for text dumps, but what
>> about for tar or custom dumps?
> Wouldn't it be more effective to test for non zero return status as this
> handles -Fc cases, etc, which would be non-trivial to test.
In the tar and custom archive formats, it's fairly obvious if the file
was truncated: you'll have table-of-contents entries that point past
the end of file. The only case that really needs an endmarker is
textual scripts --- both straight from pg_dump, and produced by
pg_restore.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2004-03-30 15:19:21 | Re: Better support for whole-row operations and composite |
| Previous Message | Bruce Momjian | 2004-03-30 14:13:10 | Re: pg_dump end comment |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-03-30 16:20:09 | Re: Dates BC. |
| Previous Message | Bruce Momjian | 2004-03-30 14:13:10 | Re: pg_dump end comment |