Skip site navigation (1) Skip section navigation (2)

Re: ecpglib use PQconnectdbParams

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, Christian Ullrich <chris(at)chrullrich(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpglib use PQconnectdbParams
Date: 2012-02-08 15:19:40
Message-ID: 17170.1328714380@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>  		if (IsUnderPostmaster)
>  			ereport(FATAL,
>  					(errcode(ERRCODE_SYNTAX_ERROR),
> -				 errmsg("invalid command-line arguments for server process"),
> +				 errmsg("invalid command-line arguments for server process: %s", argv[optind]),
>  			  errhint("Try \"%s --help\" for more information.", progname)));
>  		else
>  			ereport(FATAL,

+1 for that change, but please s/arguments/argument/ in the text.  Also,
what about the other branch of the "if" that's just out of sight here?

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2012-02-08 15:57:38
Subject: Re: Progress on fast path sorting, btree index creation time
Previous:From: Robert HaasDate: 2012-02-08 15:17:36
Subject: Re: Progress on fast path sorting, btree index creation time

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group