Re: pgbench - allow empty queries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - allow empty queries
Date: 2016-08-19 21:35:10
Message-ID: 17153.1471642510@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> I wanted to test overheads on an empty query, but pgbench does not allow
> it. I do not see why not.

I'm inclined to think this was probably a good thing before 9.6, as a
guard against accidentally writing an empty query into a script and
thus executing more queries than you meant to. However, with the new
end-of-command definition I think it's impossible to write an empty
query without an explicit ";", so it seems fine now. Pushed.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-08-19 21:41:40 Re: pgbench - minor doc improvements
Previous Message Tom Lane 2016-08-19 21:16:26 Re: Show dropped users' backends in pg_stat_activity