Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,
Date: 2011-03-11 14:31:44
Message-ID: 17148.1299853904@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> Yeah, since I like the former, I changed the wordings in the doc and
> recovery.conf.sample. What about the attached patch?

Please stop plastering the code with elog(FATAL) calls.  Those are
hardly ever appropriate.  In contexts where it might be reasonable
to do that, the error handler will treat ERROR like FATAL anyway.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2011-03-11 14:36:30
Subject: Re: Indent authentication overloading
Previous:From: Nikhil SontakkeDate: 2011-03-11 14:28:05
Subject: Re: Fwd: index corruption in PG 8.3.13

pgsql-committers by date

Next:From: Bruce MomjianDate: 2011-03-11 15:24:24
Subject: pgsql: Adds index entries for session_user and pg_describe_object
Previous:From: Bruce MomjianDate: 2011-03-11 13:48:07
Subject: pgsql: In plpsql docs, use RAISE rather than undefined log function.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group