Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Hmm, OK. But what happens if the user doesn't specify a schema name explicitly?
For the creation case, RangeVarGetCreationNamespace should handle that.
The code Dimitri quoted is wrong, but not that hard to fix.
Unfortunately, the code he quoted for the ALTER case is also wrong,
and harder to fix. Until you've done the lookup you don't know which
schema the referenced object is in. And I don't care for the idea of
doing the lookup twice, as (a) it'll be slower and (b) there are race
cases where it will give the wrong answer, ie return an object other
than the one the ALTER eventually acts on.
Really I think there is not any single point where you can put the
command-trigger hook and be done. In almost every case, the right
place is going to be buried somewhere within the execution of the
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Dimitri Fontaine||Date: 2012-01-20 19:59:59|
|Subject: Re: Command Triggers|
|Previous:||From: Tom Lane||Date: 2012-01-20 19:21:16|
|Subject: Re: JSON for PG 9.2 |