Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch to log usage of temporary files

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Bill Moran <wmoran(at)collaborativefusion(dot)com>
Cc: "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch to log usage of temporary files
Date: 2007-01-04 14:56:18
Message-ID: 16750.1167922578@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bill Moran <wmoran(at)collaborativefusion(dot)com> writes:
> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> Might be more robust to say
>>> if (trace_temp_files >= 0)

> I specified in the GUC config that minimum allowable value is -1.

I'd still tend to go with Andrew's suggestion because it makes this
particular bit of code self-defending against bad values.  Yes, it's
reasonably safe given that bit of coding way over yonder in guc.c,
but there's no particularly good reason why this code has to depend
on that to avoid doing something stupid.  And it's easier to understand
too --- you don't have to go looking in guc.c to convince yourself it's
safe.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-01-04 15:00:56
Subject: Re: wal_checksum = on (default) | off
Previous:From: Simon RiggsDate: 2007-01-04 14:43:18
Subject: Re: 8.3 pending patch queue

pgsql-patches by date

Next:From: Tom LaneDate: 2007-01-04 15:00:56
Subject: Re: wal_checksum = on (default) | off
Previous:From: Andrew DunstanDate: 2007-01-04 14:34:42
Subject: Re: [HACKERS] Patch to log usage of temporary files

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group