Re: snprintf causes regression tests to fail

From: pgsql(at)mohawksoft(dot)com
To: "Nicolai Tufar" <ntufar(at)gmail(dot)com>
Cc: "Magnus Hagander" <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: snprintf causes regression tests to fail
Date: 2005-02-28 17:54:44
Message-ID: 16737.24.91.171.78.1109613284.squirrel@mail.mohawksoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

> Linux and Solaris 10 x86 pass regression tests fine when I force the use
> of new
> snprintf(). The problem should be win32 - specific. I will
> investigate it throughly
> tonight. Can someone experienced in win32 what can possibly be the
> problem?

Do we have any idea about what format string causes the regression failure?
It may be that certain integer types are not promoted uniformly when
pushed on the stack.

>
> Nick
>
> On Sun, 27 Feb 2005 19:07:16 +0100, Magnus Hagander <mha(at)sollentuna(dot)net>
> wrote:
>> Hi!
>>
>> The new snpritnf code appears not to deal with 64-bit ints. I'm getting
>> failures on win32 for int8 as well as all the time related tests (win32
>> uses int8 for tinmestamps). Removing the snprintf code and falling back
>> to the OS code makes everything pass again.
>>
>> I would guess this affects int8 etc on other platforms as well (assuming
>> they use our snprintf and not the libc one), but I haven't checked it.
>>
>> //Magnus
>>
>>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
> joining column's datatypes do not match
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephan Szabo 2005-02-28 18:09:55 Re: serial as FK ?
Previous Message Andreas Pflug 2005-02-28 17:43:25 Re: Problems With PGAdmin

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Nicolai Tufar 2005-02-28 19:42:37 Re: snprintf causes regression tests to fail
Previous Message Bruce Momjian 2005-02-28 14:17:20 Re: snprintf causes regression tests to fail

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-02-28 19:01:16 Re: Patch for Array min() / max()
Previous Message Bruce Momjian 2005-02-28 14:21:41 Re: int4 <-> bool casts