Skip site navigation (1) Skip section navigation (2)

Re: pgstattuple locking fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Subject: Re: pgstattuple locking fix
Date: 2007-10-22 17:32:06
Message-ID: 16712.1193074326@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> On second thought, we do call PageGetHeapFreeSpace without holding a
> lock in heap_page_prune_opt as well, so it better be safe. Looking
> closer at PageGetHeapFreeSpace, I think it is. The
> return value can be bogus, of course.

> That's worth noting in the comments:

On closer look, the comments in heap_page_prune_opt seem to address
the issue already, and I'm not sure why we should comment
PageGetHeapFreeSpace this way but not all the other variants in
bufpage.c.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Hannu KrosingDate: 2007-10-23 07:20:48
Subject: Re: Including Snapshot Info with Indexes
Previous:From: Tom LaneDate: 2007-10-22 17:21:04
Subject: Re: pgstattuple locking fix

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group