Skip site navigation (1) Skip section navigation (2)

Re: void * cast cleanup

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: void * cast cleanup
Date: 2004-09-27 01:49:35
Message-ID: 16711.1096249775@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> Would anyone object to me removing some more void * casts, e.g. the
> parameters to the various _walker functions?

I'm a bit concerned about introducing warnings from not-quite-with-it
compilers.  Are there any still out there that would treat this as a
bogus conversion?

While I agree that casting pfree's argument is just pedantry, I'm not
quite sold on the proposition for less well-known functions such as
the _walker family.  You could take it as a flag that "yes I mean to
treat this pointer as a generic object now".  I'm not dead set on that
reasoning but it's something to think about.

Any other opinions out there?

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2004-09-27 02:03:07
Subject: Re: void * cast cleanup
Previous:From: Neil ConwayDate: 2004-09-27 00:23:11
Subject: Re: WIP: CREATE TABLE AS / WITH DATA

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group