Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] snprintf causes regression

From: pgsql(at)mohawksoft(dot)com
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Nicolai Tufar" <ntufar(at)gmail(dot)com>,"Magnus Hagander" <mha(at)sollentuna(dot)net>,"PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>,"PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Date: 2005-03-11 17:02:29
Message-ID: 16655.24.91.171.78.1110560549.squirrel@mail.mohawksoft.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
> Tom Lane wrote:
>> pgsql(at)mohawksoft(dot)com writes:
>> >>> Please see my posting about using a macro for snprintf.
>>
>> > Wasn't the issue about odd behavior of the Win32 linker choosing the
>> wrong
>> > vnsprintf?
>>
>> You're right, the point about the macro was to avoid linker weirdness on
>> Windows.  We need to do that part in any case.  I think Bruce confused
>> that issue with the one about whether our version supported %n$
>> adequately ... which it doesn't just yet ...
>
> Perhaps I am reading old email in this reply but I thought I should
> clarify:
>
> Once we do:
>
> 	#define vsnprintf(...)        pg_vsnprintf(__VA_ARGS__)
> 	#define snprintf(...)         pg_snprintf(__VA_ARGS__)
> 	#define printf(...)           pg_printf(__VA_ARGS__)


I'm not sure that macros can have variable number of arguments on all
supported platforms. I've been burnt by this before.


In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2005-03-11 17:12:03
Subject: Re: TODO item: support triggers on columns
Previous:From: David FetterDate: 2005-03-11 16:49:01
Subject: Re: [HACKERS] PostgreSQL pam ldap document

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-03-11 17:14:26
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Previous:From: Kris KigerDate: 2005-03-11 16:48:46
Subject: Re: Functions and transactions

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2005-03-11 17:14:26
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Previous:From: Bruce MomjianDate: 2005-03-11 16:21:23
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group