| From: | pgsql(at)mohawksoft(dot)com |
|---|---|
| To: | "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Nicolai Tufar" <ntufar(at)gmail(dot)com>, "Magnus Hagander" <mha(at)sollentuna(dot)net>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, "PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org> |
| Subject: | Re: [pgsql-hackers-win32] snprintf causes regression |
| Date: | 2005-03-11 17:02:29 |
| Message-ID: | 16655.24.91.171.78.1110560549.squirrel@mail.mohawksoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
> Tom Lane wrote:
>> pgsql(at)mohawksoft(dot)com writes:
>> >>> Please see my posting about using a macro for snprintf.
>>
>> > Wasn't the issue about odd behavior of the Win32 linker choosing the
>> wrong
>> > vnsprintf?
>>
>> You're right, the point about the macro was to avoid linker weirdness on
>> Windows. We need to do that part in any case. I think Bruce confused
>> that issue with the one about whether our version supported %n$
>> adequately ... which it doesn't just yet ...
>
> Perhaps I am reading old email in this reply but I thought I should
> clarify:
>
> Once we do:
>
> #define vsnprintf(...) pg_vsnprintf(__VA_ARGS__)
> #define snprintf(...) pg_snprintf(__VA_ARGS__)
> #define printf(...) pg_printf(__VA_ARGS__)
I'm not sure that macros can have variable number of arguments on all
supported platforms. I've been burnt by this before.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2005-03-11 17:12:03 | Re: TODO item: support triggers on columns |
| Previous Message | David Fetter | 2005-03-11 16:49:01 | Re: [HACKERS] PostgreSQL pam ldap document |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-03-11 17:14:26 | Re: [pgsql-hackers-win32] snprintf causes regression |
| Previous Message | Bruce Momjian | 2005-03-11 16:21:23 | Re: [pgsql-hackers-win32] snprintf causes regression tests |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-03-11 17:14:26 | Re: [pgsql-hackers-win32] snprintf causes regression |
| Previous Message | Kris Kiger | 2005-03-11 16:48:46 | Re: Functions and transactions |