Re: [pgsql-hackers-win32] snprintf causes regression

From: pgsql(at)mohawksoft(dot)com
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Nicolai Tufar" <ntufar(at)gmail(dot)com>, "Magnus Hagander" <mha(at)sollentuna(dot)net>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>, "PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Date: 2005-03-11 01:29:49
Message-ID: 16512.24.91.171.78.1110504589.squirrel@mail.mohawksoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

> Tom Lane wrote:
>> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> > Please see my posting about using a macro for snprintf. If the
>> current
>> > implementation of snprintf is enough for our existing translation
>> users
>> > we probably don't need to add anything more to it because snprintf
>> will
>> > not be exported to client applications.
>>
>> The CVS-tip implementation is fundamentally broken and won't work even
>> for our internal uses. I've not wasted time complaining about it
>> because I thought we were going to replace it. If we can't find a
>> usable replacement then we're going to have to put a lot of effort
>> into fixing what's there. On the whole I think the effort would be
>> better spent importing someone else's solution.
>
> Oh, so our existing implementation doesn't even meet our needs. OK.

Wasn't the issue about odd behavior of the Win32 linker choosing the wrong
vnsprintf?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Brown 2005-03-11 02:00:08 Re: fool-toleranced optimizer
Previous Message Christopher Kings-Lynne 2005-03-11 01:27:03 Re: Raw size

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2005-03-11 03:58:27 Re: [pgsql-hackers-win32] snprintf causes regression tests
Previous Message Bruce Momjian 2005-03-11 00:21:41 Re: [pgsql-hackers-win32] snprintf causes regression tests

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2005-03-11 03:54:50 Re: trivial refactoring of WaitOnLock
Previous Message Bruce Momjian 2005-03-11 00:21:41 Re: [pgsql-hackers-win32] snprintf causes regression tests