Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] snprintf causes regression

From: pgsql(at)mohawksoft(dot)com
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Nicolai Tufar" <ntufar(at)gmail(dot)com>,"Magnus Hagander" <mha(at)sollentuna(dot)net>,"PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>,"PostgreSQL Win32 port list" <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Date: 2005-03-11 01:29:49
Message-ID: 16512.24.91.171.78.1110504589.squirrel@mail.mohawksoft.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
> Tom Lane wrote:
>> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> > Please see my posting about using a macro for snprintf.  If the
>> current
>> > implementation of snprintf is enough for our existing translation
>> users
>> > we probably don't need to add anything more to it because snprintf
>> will
>> > not be exported to client applications.
>>
>> The CVS-tip implementation is fundamentally broken and won't work even
>> for our internal uses.  I've not wasted time complaining about it
>> because I thought we were going to replace it.  If we can't find a
>> usable replacement then we're going to have to put a lot of effort
>> into fixing what's there.  On the whole I think the effort would be
>> better spent importing someone else's solution.
>
> Oh, so our existing implementation doesn't even meet our needs. OK.

Wasn't the issue about odd behavior of the Win32 linker choosing the wrong
vnsprintf?

In response to

Responses

pgsql-hackers by date

Next:From: Kevin BrownDate: 2005-03-11 02:00:08
Subject: Re: fool-toleranced optimizer
Previous:From: Christopher Kings-LynneDate: 2005-03-11 01:27:03
Subject: Re: Raw size

pgsql-patches by date

Next:From: Neil ConwayDate: 2005-03-11 03:54:50
Subject: Re: trivial refactoring of WaitOnLock
Previous:From: Bruce MomjianDate: 2005-03-11 00:21:41
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2005-03-11 03:58:27
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests
Previous:From: Bruce MomjianDate: 2005-03-11 00:21:41
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group