Re: Datum should be defined outside postgres.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Datum should be defined outside postgres.h
Date: 2007-10-25 15:31:15
Message-ID: 16470.1193326275@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> Tom Lane wrote:
>> Why in the world is ecpg including either primnodes.h or postgres.h?

> The problem is that ecpg shares parser.c source code and this code
> includes postgres.h.

ecpg cannot do that. It would fail if parser.c happened to use anything
that won't compile in frontend, eg elog() or palloc(). It's mere luck
that it's worked for him so far.

Considering that ecpg has its own copy of all of gram.y and scan.l,
sharing parser.c isn't much of a savings anyway.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zdenek Kotala 2007-10-25 15:35:23 Re: Datum should be defined outside postgres.h
Previous Message Jonah H. Harris 2007-10-25 15:22:54 Re: Opportunity for a Radical Changes in Database Software