| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: The dbase conrtib doesn't compile |
| Date: | 2001-12-21 05:12:40 |
| Message-ID: | 16450.1008911560@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Yes, glad you pointed it out. I think the best solution is to remove
> #define HAVE_ICONV_H and -liconv so it will work fine on all platforms.
> If someone wants the iconv conversions, they can add the needed #define
> and link library, OK?
That seems like a plan. Perhaps add some commented-out macro
definitions to the makefile to make it a simple addition. Something
like
# Uncomment this to provide charset translation
# CFLAGS += -DHAVE_ICONV_H
# You might need to uncomment this too, if libiconv is a separate
# library on your platform
# LIBS += -liconv
Untested but you get the idea ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-12-21 05:29:34 | Re: The dbase conrtib doesn't compile |
| Previous Message | Bruce Momjian | 2001-12-21 05:07:20 | Re: The dbase conrtib doesn't compile |