From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Bruce Momjian <bruce(at)momjian(dot)us>
Cc:
Simon Riggs <simon(at)2ndquadrant(dot)com>,
Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject:
Re: [HACKERS] Deadlock with pg_dump?
Date:
2007-03-02 20:55:05
Message-ID:
16441.1172868905@sss.pgh.pa.us (view raw or flat )
Thread:
2006-10-26 20:45:02 from Chris Campbell <chris(at)bignerdranch(dot)com>
2006-10-26 21:21:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2006-10-26 22:11:59 from Chris Campbell <chris(at)bignerdranch(dot)com>
2006-10-26 22:29:11 from "Jim C(dot) Nasby" <jim(at)nasby(dot)net>
2006-10-26 22:45:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2006-10-26 23:23:12 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2006-10-27 00:27:31 from Chris Campbell <chris(at)bignerdranch(dot)com>
2006-10-30 20:49:57 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-14 03:19:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-02-19 19:38:41 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-19 22:29:40 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 18:34:01 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-02-26 19:01:24 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 19:11:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-26 19:19:49 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 19:28:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-26 19:31:49 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 19:52:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-26 20:05:07 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 20:10:49 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-02-26 20:15:43 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-01 02:06:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-01 05:45:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-01 14:06:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-01 19:17:20 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 18:35:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 18:51:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 20:20:27 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 20:55:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 22:05:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 22:37:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 22:46:40 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 23:38:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-03 02:40:54 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-03 02:43:54 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-03 18:49:32 from Bruce Momjian <bruce(at)momjian(dot)us>
2006-11-21 04:40:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-hackers pgsql-patches
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I can create a global variable to control this, but the new elog level
> seemed cleaner.
What I don't like about the proposed patch is that it's nonorthogonal.
I see no reason to suppose that LOG is the only possible elevel for
which it might be interesting to suppress the STATEMENT: field.
Perhaps the best thing would be to define an additional ereport
auxiliary function, say errprintstmt(bool), that could set a flag
in the current elog stack entry to control suppression of STATEMENT.
This would mean you couldn't determine the behavior when using elog(),
but that's not supposed to be used for user-facing messages anyway.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Alvaro HerreraDate: 2007-03-02 21:37:05Subject : Re: HOT - preliminary resultsPrevious :From : Bruce MomjianDate : 2007-03-02 20:53:24Subject : Re: HOT - preliminary results
pgsql-patches by date
Next :From: Jeremy DrakeDate: 2007-03-02 21:47:50Subject : cosmetic patch to large object regression testPrevious :From : Bruce MomjianDate : 2007-03-02 20:20:58Subject : Re: Final version of IDENTITY/GENERATED patch
