PostgreSQL Weekly News - October 24, 2021

# PostgreSQL Weekly News - October 24, 2021

# PostgreSQL Product News

JDBC 42.3.0
[released](https://jdbc.postgresql.org/documentation/changelog.html#version_42.3.0).

pgmetrics 1.12, a command-line tool for PostgreSQL metrics,
[released](https://pgmetrics.io/).

StackGres 1.0.0, a platform for running PostgreSQL on Kubernetes, released.
https://stackgres.io/

pgexporter 0.2.0, a Prometheus exporter for PostgreSQL,
[released](https://pgexporter.github.io///release/announcement/2021/10/20/pgexporter-0.2.0.html)

pgAdmin4 6.1, a web- and native GUI control center for PostgreSQL,
[released](https://www.pgadmin.org/docs/pgadmin4/6.1/release_notes_6_1.html).

# PostgreSQL Jobs for October

[https://archives.postgresql.org/pgsql-jobs/2021-10/](https://archives.postgresql.org/pgsql-jobs/2021-10/)

# PostgreSQL in the News

Planet PostgreSQL: [https://planet.postgresql.org/](https://planet.postgresql.org/)

PostgreSQL Weekly News is brought to you this week by David Fetter

Submit news and announcements by Sunday at 3:00pm PST8PDT to david(at)fetter(dot)org(dot)

# Applied Patches

Michaël Paquier pushed:

- Fix portability issues in new TAP tests of psql. The tests added by c0280bc
and d9ddc50 in 001_basic.pl have introduced commands calling directly psql,
making them sensitive to the environment. One issue was that those commands
forgot -X to not use a local .psqlrc, causing all those tests to fail if psql
cannot properly parse this file. TAP tests should be designed so as they run
in an isolated fashion, without any dependency on the environment where they
are run. As PostgresNode::psql gives already all the facilities those new
tests need, switch to that instead of calling plain psql commands where
interactions with a backend are needed. The test is slightly refactored to be
able to check after the expected patterns of stdout and stderr, keeping the
same amount of coverage as previously. Reported-by: Peter Geoghegan
Discussion:
[https://postgr.es/m/CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com](https://postgr.es/m/CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com)
[https://git.postgresql.org/pg/commitdiff/384f1abdb9b0f669279fcd57ba2173eb31724740](https://git.postgresql.org/pg/commitdiff/384f1abdb9b0f669279fcd57ba2173eb31724740)

- Reset properly snapshot export state during transaction abort. During a
replication slot creation, an ERROR generated in the same transaction as the
one creating a to-be-exported snapshot would have left the backend in an
inconsistent state, as the associated static export snapshot state was not
being reset on transaction abort, but only on the follow-up command received
by the WAL sender that created this snapshot on replication slot creation.
This would trigger inconsistency failures if this session tried to export
again a snapshot, like during the creation of a replication slot. Note that a
snapshot export cannot happen in a transaction block, so there is no need to
worry resetting this state for subtransaction aborts. Also, this inconsistent
state would very unlikely show up to users. For example, one case where this
could happen is an out-of-memory error when building the initial snapshot
to-be-exported. Dilip found this problem while poking at a different patch,
that caused an error in this code path for reasons unrelated to HEAD. Author:
Dilip Kumar Reviewed-by: Michael Paquier, Zhihong Yu Discussion:
[https://postgr.es/m/CAFiTN-s0zA1Kj0ozGHwkYkHwa5U0zUE94RSc_g81WrpcETB5=w@mail.gmail.com](https://postgr.es/m/CAFiTN-s0zA1Kj0ozGHwkYkHwa5U0zUE94RSc_g81WrpcETB5=w@mail.gmail.com)
Backpatch-through: 9.6
[https://git.postgresql.org/pg/commitdiff/409f9ca4471331be0f77b665ff3a1836a41de5b3](https://git.postgresql.org/pg/commitdiff/409f9ca4471331be0f77b665ff3a1836a41de5b3)

- Block ALTER INDEX/TABLE index_name ALTER COLUMN colname SET (options). The
grammar of this command run on indexes with column names has always been
authorized by the parser, and it has never been documented. Since 911e702, it
is possible to define opclass parameters as of CREATE INDEX, which actually
broke the old case of ALTER INDEX/TABLE where relation-level parameters
n_distinct and n_distinct_inherited could be defined for an index (see 76a47c0
and its thread where this point has been touched, still remained unused).
Attempting to do that in v13~ would cause the index to become unusable, as
there is a new dedicated code path to load opclass parameters instead of the
relation-level ones previously available. Note that it is possible to fix
things with a manual catalog update to bring the relation back online. This
commit disables this command for now as the use of column names for indexes
does not make sense anyway, particularly when it comes to index expressions
where names are automatically computed. One way to properly support this case
properly in the future would be to use column numbers when it comes to
indexes, in the same way as ALTER INDEX .. ALTER COLUMN .. SET STATISTICS.
Partitioned indexes were already blocked, but not indexes. Some tests are
added for both cases. There was some code in ANALYZE to enforce n_distinct to
be used for an index expression if the parameter was defined, but just remove
it for now until/if there is support for this (note that index-level
parameters never had support in pg_dump either, previously), so this was just
dead code. Reported-by: Matthijs van der Vleuten Author: Nathan Bossart,
Michael Paquier Reviewed-by: Vik Fearing, Dilip Kumar Discussion:
[https://postgr.es/m/17220-15d684c6c2171a83@postgresql.org](https://postgr.es/m/17220-15d684c6c2171a83@postgresql.org)
Backpatch-through: 13
[https://git.postgresql.org/pg/commitdiff/fdd88571454e2b00dbe446e8609c6e4294ca89ae](https://git.postgresql.org/pg/commitdiff/fdd88571454e2b00dbe446e8609c6e4294ca89ae)

- Fix build of MSVC with OpenSSL 3.0.0. The build scripts of Visual Studio would
fail to detect properly a 3.0.0 build as the check on the second digit was
failing. This is adjusted where needed, allowing the builds to complete.
Note that the MSIs of OpenSSL mentioned in the documentation have not changed
any library names for Win32 and Win64, making this change straight-forward.
Reported-by: htalaco, via github Reviewed-by: Daniel Gustafsson Discussion:
[https://postgr.es/m/YW5XKYkq6k7OtrFq@paquier.xyz](https://postgr.es/m/YW5XKYkq6k7OtrFq@paquier.xyz)
Backpatch-through: 9.6
[https://git.postgresql.org/pg/commitdiff/41f30ecc29c89285d3eecd435906c4e9cb048be4](https://git.postgresql.org/pg/commitdiff/41f30ecc29c89285d3eecd435906c4e9cb048be4)

- Fix corruption of pg_shdepend when copying deps from template database. Using
for a new database a template database with shared dependencies that need to
be copied over was causing a corruption of pg_shdepend because of an
off-by-one computation error of the index number used for the values inserted
with a slot. Issue introduced by e3931d0. Monitoring the rest of the code,
there are no similar mistakes. Reported-by: Sven Klemm Author: Aleksander
Alekseev Reviewed-by: Daniel Gustafsson, Michael Paquier Discussion:
[https://postgr.es/m/CAJ7c6TP0AowkUgNL6zcAK-s5HYsVHVBRWfu69FRubPpfwZGM9A@mail.gmail.com](https://postgr.es/m/CAJ7c6TP0AowkUgNL6zcAK-s5HYsVHVBRWfu69FRubPpfwZGM9A@mail.gmail.com)
Backpatch-through: 14
[https://git.postgresql.org/pg/commitdiff/98ec35b0bbf6003e89fc06aa140e12fd90bbad47](https://git.postgresql.org/pg/commitdiff/98ec35b0bbf6003e89fc06aa140e12fd90bbad47)

- doc: Describe calculation method of streaming start for pg_receivewal. The
documentation was imprecise about the starting LSN used for WAL streaming if
nothing can be found in the local archive directory defined with the
pg_receivewal command, so be more talkative on this matter. Extracted from a
larger patch by the same author. Author: Ronan Dunklau, Michael Paquier
Discussion:
[https://postgr.es/m/18708360.4lzOvYHigE@aivenronan](https://postgr.es/m/18708360.4lzOvYHigE@aivenronan)
Backpatch-through: 10
[https://git.postgresql.org/pg/commitdiff/1e9475694b0ae2cf1204d01d2ef6ad86f3c7cac8](https://git.postgresql.org/pg/commitdiff/1e9475694b0ae2cf1204d01d2ef6ad86f3c7cac8)

Heikki Linnakangas pushed:

- Replace polyphase merge algorithm with a simple balanced k-way merge. The
advantage of polyphase merge is that it can reuse the input tapes as output
tapes efficiently, but that is irrelevant on modern hardware, when we can
easily emulate any number of tape drives. The number of input tapes we
can/should use during merging is limited by work_mem, but output tapes that we
are not currently writing to only cost a little bit of memory, so there is no
need to skimp on them. This makes sorts that need multiple merge passes
faster. Discussion:
[https://www.postgresql.org/message-id/420a0ec7-602c-d406-1e75-1ef7ddc58d83%40iki.fi](https://www.postgresql.org/message-id/420a0ec7-602c-d406-1e75-1ef7ddc58d83%40iki.fi)
Reviewed-by: Peter Geoghegan, Zhihong Yu, John Naylor
[https://git.postgresql.org/pg/commitdiff/65014000b351d5725eb00d133416ab1b4f8245b1](https://git.postgresql.org/pg/commitdiff/65014000b351d5725eb00d133416ab1b4f8245b1)

- Refactor LogicalTapeSet/LogicalTape interface. All the tape functions, like
LogicalTapeRead and LogicalTapeWrite, now take a LogicalTape as argument,
instead of LogicalTapeSet+tape number. You can create any number of
LogicalTapes in a single LogicalTapeSet, and you don't need to decide the
number upfront, when you create the tape set. This makes the tape management
in hash agg spilling in nodeAgg.c simpler. Discussion:
[https://www.postgresql.org/message-id/420a0ec7-602c-d406-1e75-1ef7ddc58d83%40iki.fi](https://www.postgresql.org/message-id/420a0ec7-602c-d406-1e75-1ef7ddc58d83%40iki.fi)
Reviewed-by: Peter Geoghegan, Zhihong Yu, John Naylor
[https://git.postgresql.org/pg/commitdiff/c4649cce39a41b27db874e75ddd47adaec1b0ea4](https://git.postgresql.org/pg/commitdiff/c4649cce39a41b27db874e75ddd47adaec1b0ea4)

- Fix format modifier used in elog. The previous commit 65014000b3 changed the
variable passed to elog from an int64 to a size_t variable, but neglected to
change the modifier in the format string accordingly. Per failure on
buildfarm member lapwing.
[https://git.postgresql.org/pg/commitdiff/0bd65a3905706927cdd6b3158b6457c1c854471b](https://git.postgresql.org/pg/commitdiff/0bd65a3905706927cdd6b3158b6457c1c854471b)

- Fix duplicate typedef LogicalTape. To make buildfarm member locust happy.
[https://git.postgresql.org/pg/commitdiff/aa3ac6453b28049b3198433b75228271b7612d4a](https://git.postgresql.org/pg/commitdiff/aa3ac6453b28049b3198433b75228271b7612d4a)

- Fix parallel sort, broken by the balanced merge patch. The code for
initializing the tapes on each merge iteration was skipped in a parallel
worker. I put the !WORKER(state) check in wrong place while rebasing the
patch. That caused failures in the index build in 'multiple-row-versions'
isolation test, in multiple buildfarm members. On my laptop it was easier to
reproduce by building an index on a larger table, so that you got a parallel
sort more reliably.
[https://git.postgresql.org/pg/commitdiff/fc0f3b4cb0e882a9c5d51c302d4aa3591e4f80fd](https://git.postgresql.org/pg/commitdiff/fc0f3b4cb0e882a9c5d51c302d4aa3591e4f80fd)

Álvaro Herrera pushed:

- Invalidate partitions of table being attached/detached. Failing to do that,
any direct inserts/updates of those partitions would fail to enforce the
correct constraint, that is, one that considers the new partition constraint
of their parent table. Backpatch to 10. Reported by: Hou Zhijie
<houzj(dot)fnst(at)fujitsu(dot)com> Author: Amit Langote <amitlangote09(at)gmail(dot)com>
Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> Reviewed-by: Nitin Jadhav
<nitinjadhavpostgres(at)gmail(dot)com> Reviewed-by: Pavel Borisov
<pashkin(dot)elfe(at)gmail(dot)com> Discussion:
[https://postgr.es/m/OS3PR01MB5718DA1C4609A25186D1FBF194089%40OS3PR01MB5718.jpnprd01.prod.outlook.com](https://postgr.es/m/OS3PR01MB5718DA1C4609A25186D1FBF194089%40OS3PR01MB5718.jpnprd01.prod.outlook.com)
[https://git.postgresql.org/pg/commitdiff/d6f1e16c8fe27100e371a15aeeb498faa680ceed](https://git.postgresql.org/pg/commitdiff/d6f1e16c8fe27100e371a15aeeb498faa680ceed)

- Ensure correct lock level is used in ALTER ... RENAME. Commit 1b5d797cd4f7
intended to relax the lock level used to rename indexes, but inadvertently
allowed *any* relation to be renamed with a lowered lock level, as long as the
command is spelled ALTER INDEX. That's undesirable for other relation types,
so retry the operation with the higher lock if the relation turns out not to
be an index. After this fix, ALTER INDEX <sometable> RENAME will require
access exclusive lock, which it didn't before. Author: Nathan Bossart
<bossartn(at)amazon(dot)com> Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Reported-by: Onder Kalaci <onderk(at)microsoft(dot)com> Discussion:
[https://postgr.es/m/PH0PR21MB1328189E2821CDEC646F8178D8AE9@PH0PR21MB1328.namprd21.prod.outlook.com](https://postgr.es/m/PH0PR21MB1328189E2821CDEC646F8178D8AE9@PH0PR21MB1328.namprd21.prod.outlook.com)
[https://git.postgresql.org/pg/commitdiff/c2c618ff1137f9ef58827f57e4ec0f97453e454e](https://git.postgresql.org/pg/commitdiff/c2c618ff1137f9ef58827f57e4ec0f97453e454e)

- Protect against collation variations in test. Discussion:
[https://postgr.es/m/YW/MYdSRQZtPFBWR(at)paquier(dot)xyz](https://postgr.es/m/YW/MYdSRQZtPFBWR(at)paquier(dot)xyz)
[https://git.postgresql.org/pg/commitdiff/cd124d205c42a623b68cd155ace94cc376851b78](https://git.postgresql.org/pg/commitdiff/cd124d205c42a623b68cd155ace94cc376851b78)

Daniel Gustafsson pushed:

- Fix sscanf limits in pg_basebackup and pg_dump. Make sure that the string
parsing is limited by the size of the destination buffer. In pg_basebackup
the available values sent from the server is limited to two characters so
there was no risk of overflow. In pg_dump the buffer is bounded by MAXPGPATH,
and thus the limit must be inserted via preprocessor expansion and the buffer
increased by one to account for the terminator. There is no risk of overflow
here, since in this case, the buffer scanned is smaller than the destination
buffer. Backpatch the pg_basebackup fix to 11 where it was introduced, and
the pg_dump fix all the way down to 9.6. Reviewed-by: Tom Lane Discussion:
[https://postgr.es/m/B14D3D7B-F98C-4E20-9459-C122C67647FB@yesql.se](https://postgr.es/m/B14D3D7B-F98C-4E20-9459-C122C67647FB@yesql.se)
Backpatch-through: 11 and 9.6
[https://git.postgresql.org/pg/commitdiff/1d7641d51a51aa00dff685022fab6c03be8f8af8](https://git.postgresql.org/pg/commitdiff/1d7641d51a51aa00dff685022fab6c03be8f8af8)

- Fix bug in TOC file error message printing. If the blob TOC file cannot be
parsed, the error message was failing to print the filename as the variable
holding it was shadowed by the destination buffer for parsing. When the
filename fails to parse, the error will print an empty string: ./pg_restore
-d foo -F d dump pg_restore: error: invalid line in large object TOC file "":
.. ..instead of the intended error message: ./pg_restore -d foo -F d dump
pg_restore: error: invalid line in large object TOC file "dump/blobs.toc": ..
Fix by renaming both variables as the shared name was too generic to store
either and still convey what the variable held. Backpatch all the way down to
9.6. Reviewed-by: Tom Lane Discussion:
[https://postgr.es/m/A2B151F5-B32B-4F2C-BA4A-6870856D9BDE@yesql.se](https://postgr.es/m/A2B151F5-B32B-4F2C-BA4A-6870856D9BDE@yesql.se)
Backpatch-through: 9.6
[https://git.postgresql.org/pg/commitdiff/998d060f3db79c6918cb4a547695be150833f9a4](https://git.postgresql.org/pg/commitdiff/998d060f3db79c6918cb4a547695be150833f9a4)

- Refactor the sslfiles Makefile target for ease of use. The Makefile handling
of certificate and keypairs used for TLS testing had become quite difficult to
work with. Adding a new cert without the need to regenerate everything was too
complicated. This patch refactors the sslfiles make target such that adding a
new certificate requires only adding a .config file, adding it to the top of
the Makefile, and running make sslfiles. Improvements: - Interfile
dependencies should be fixed, with the exception of the CRL dirs. - New
certificates have serial numbers based on the current time, reducing the
chance of collision. - The CA index state is created on demand and cleaned up
automatically at the end of the Make run. - `*.config` files are now
self-contained; one certificate needs one config file instead of two. -
Duplication is reduced, and along with it some unneeded code (and possible
copy-paste errors). - all configuration files underneath the conf/ directory.
The target is moved to its own makefile in order to avoid colliding with
global make settings. Author: Jacob Champion <pchampion(at)vmware(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz> Discussion:
[https://postgr.es/m/d15a9838344ba090e09fd866abf913584ea19fb7.camel@vmware.com](https://postgr.es/m/d15a9838344ba090e09fd866abf913584ea19fb7.camel@vmware.com)
[https://git.postgresql.org/pg/commitdiff/b4c4a00eada3c512e819e9163114a5ad1606bc7e](https://git.postgresql.org/pg/commitdiff/b4c4a00eada3c512e819e9163114a5ad1606bc7e)

- Fix SSL tests on 32-bit Perl. The certificate serial number generation was
changed in b4c4a00ea to use the current timestamp. The testharness must thus
interrogate the cert for the serialnumber using "openssl x509" which emits the
serial in hex format. Converting the serial to integer format to match whats
in pg_stat_ssl requires a 64-bit capable Perl. This adds a fallback to
checking for an integer when the tests with a 32-bit Perl. Per failure on
buildfarm member prairiedog. Discussion:
[https://postgr.es/m/0D295F43-806D-4B3F-AB98-F941A19E0271@yesql.se](https://postgr.es/m/0D295F43-806D-4B3F-AB98-F941A19E0271@yesql.se)
[https://git.postgresql.org/pg/commitdiff/0c04342b1d3dd5b24f795f94874163be8e21710e](https://git.postgresql.org/pg/commitdiff/0c04342b1d3dd5b24f795f94874163be8e21710e)

Tom Lane pushed:

- Remove bogus assertion in transformExpressionList(). I think when I added this
assertion (in commit 8f889b108), I was only thinking of the use of
transformExpressionList at top level of INSERT and VALUES. But it's also
called by transformRowExpr(), which can certainly occur in an UPDATE
targetlist, so it's inappropriate to suppose that p_multiassign_exprs must be
empty. Besides, since the input is not expected to contain ResTargets,
there's no reason it should contain MultiAssignRefs either. Hence this code
need not be concerned about the state of p_multiassign_exprs, and we should
just drop the assertion. Per bug #17236 from ocean_li_996. It's been wrong
for years, so back-patch to all supported branches. Discussion:
[https://postgr.es/m/17236-3210de9bcba1d7ca@postgresql.org](https://postgr.es/m/17236-3210de9bcba1d7ca@postgresql.org)
[https://git.postgresql.org/pg/commitdiff/697dd1925f418c9f54ee1fd1cefbc613d6504b1f](https://git.postgresql.org/pg/commitdiff/697dd1925f418c9f54ee1fd1cefbc613d6504b1f)

- Fix assignment to array of domain over composite. An update such as "UPDATE
... SET fld[n].subfld = whatever" failed if the array elements were domains
rather than plain composites. That's because isAssignmentIndirectionExpr()
failed to cope with the CoerceToDomain node that would appear in the
expression tree in this case. The result would typically be a crash, and even
if we accidentally didn't crash, we'd not correctly preserve other fields of
the same array element. Per report from Onder Kalaci. Back-patch to v11
where arrays of domains came in. Discussion:
[https://postgr.es/m/PH0PR21MB132823A46AA36F0685B7A29AD8BD9@PH0PR21MB1328.namprd21.prod.outlook.com](https://postgr.es/m/PH0PR21MB132823A46AA36F0685B7A29AD8BD9@PH0PR21MB1328.namprd21.prod.outlook.com)
[https://git.postgresql.org/pg/commitdiff/3e310d837a9b3de8ad977c0a3e2a769bcdf61cc9](https://git.postgresql.org/pg/commitdiff/3e310d837a9b3de8ad977c0a3e2a769bcdf61cc9)

- pg_dump: Reorganize getTables(). Along the same lines as 047329624, ed2c7f65b
and daa9fe8a5, reduce code duplication by having just one copy of the parts of
the query that are the same across all server versions; and make the
conditionals control the smallest possible amount of code. This also gets rid
of the confusing assortment of different ways to accomplish the same result
that we had here before. While at it, make sure all three relevant parts of
the function list the fields in the same order. This is just neatnik-ism, of
course. Discussion:
[https://postgr.es/m/1240992.1634419055@sss.pgh.pa.us](https://postgr.es/m/1240992.1634419055@sss.pgh.pa.us)
[https://git.postgresql.org/pg/commitdiff/4438eb4a495c977d8ac485dd6e544c2b6e077deb](https://git.postgresql.org/pg/commitdiff/4438eb4a495c977d8ac485dd6e544c2b6e077deb)

- Improve pg_regress.c's infrastructure for issuing psql commands. Support
issuing more than one "-c command" switch to a single psql invocation. This
allows combining some things that formerly required two or more backend
launches into a single session. In particular, we can issue DROP DATABASE as
one of the -c commands without getting "DROP DATABASE cannot run inside a
transaction block". In addition to reducing the number of sessions needed,
this patch also suppresses "NOTICE: database "foo" does not exist, skipping"
chatter that was formerly generated during pg_regress's DROP DATABASE (or
ROLE) IF NOT EXISTS calls. That moves us another step closer to the ideal of
not seeing any messages during successful build/test. This also eliminates
some hard-coded restrictions on the length of the commands issued. I don't
think we were anywhere near hitting those, but getting rid of the limit is
comforting. Patch by me, but thanks to Nathan Bossart for starting the
discussion. Discussion:
[https://postgr.es/m/DCBAE0E4-BD56-482F-8A70-7FD0DC0860BE@amazon.com](https://postgr.es/m/DCBAE0E4-BD56-482F-8A70-7FD0DC0860BE@amazon.com)
[https://git.postgresql.org/pg/commitdiff/f45dc59a38cab1d2af6baaedb79559fe2e9b3781](https://git.postgresql.org/pg/commitdiff/f45dc59a38cab1d2af6baaedb79559fe2e9b3781)

- Doc: clarify a critical and undocumented aspect of simplehash.h. I just got
burnt by trying to use pg_malloc instead of pg_malloc0 with this. Save the
next hacker some time by not leaving this API detail undocumented.
[https://git.postgresql.org/pg/commitdiff/b1ce6c284366ce1dae120f5d10dd59e8804322ee](https://git.postgresql.org/pg/commitdiff/b1ce6c284366ce1dae120f5d10dd59e8804322ee)

- pg_dump: fix mis-dumping of non-global default privileges. Non-global default
privilege entries should be dumped as-is, not made relative to the default ACL
for their object type. This would typically only matter if one had revoked
some on-by-default privileges in a global entry, and then wanted to grant them
again in a non-global entry. Per report from Boris Korzun. This is an old
bug, so back-patch to all supported branches. Neil Chen, test case by
Masahiko Sawada Discussion:
[https://postgr.es/m/111621616618184@mail.yandex.ru](https://postgr.es/m/111621616618184@mail.yandex.ru)
Discussion:
[https://postgr.es/m/CAA3qoJnr2+1dVJObNtfec=qW4Z0nz=A9+r5bZKoTSy5RDjskMw@mail.gmail.com](https://postgr.es/m/CAA3qoJnr2+1dVJObNtfec=qW4Z0nz=A9+r5bZKoTSy5RDjskMw@mail.gmail.com)
[https://git.postgresql.org/pg/commitdiff/2acc84c6fd299125702c8a8af13820abcc0d4891](https://git.postgresql.org/pg/commitdiff/2acc84c6fd299125702c8a8af13820abcc0d4891)

- Fix frontend version of sh_error() in simplehash.h. The code does not expect
sh_error() to return, but the patch that made this header usable in frontend
didn't get that memo. While here, plaster unlikely() on the tests that decide
whether to invoke sh_error(), and add our standard copyright notice. Noted by
Andres Freund. Back-patch to v13 where this frontend support came in.
Discussion:
[https://postgr.es/m/0D54435C-1199-4361-9D74-2FBDCF8EA164@anarazel.de](https://postgr.es/m/0D54435C-1199-4361-9D74-2FBDCF8EA164@anarazel.de)
[https://git.postgresql.org/pg/commitdiff/974aedcea46dfd0119eea2fbb2eeacd232596f05](https://git.postgresql.org/pg/commitdiff/974aedcea46dfd0119eea2fbb2eeacd232596f05)

- In pg_dump, use simplehash.h to look up dumpable objects by OID. Create a hash
table that indexes dumpable objects by CatalogId (that is, catalog OID +
object OID). Use this to replace the former catalogIdMap array, as well as
various other single- catalog index arrays, and also the extension membership
map. In principle this should be faster for databases with many objects,
since lookups are now O(1) not O(log N). However, it seems that these lookups
are pretty much negligible in context, so that no overall performance change
can be measured. But having only one lookup data structure to maintain makes
the code simpler and more flexible, so let's do it anyway. Discussion:
[https://postgr.es/m/2595220.1634855245@sss.pgh.pa.us](https://postgr.es/m/2595220.1634855245@sss.pgh.pa.us)
[https://git.postgresql.org/pg/commitdiff/92316a4582a5714d4e494aaf90360860e7fec37a](https://git.postgresql.org/pg/commitdiff/92316a4582a5714d4e494aaf90360860e7fec37a)

- Fix minor memory leaks in pg_dump. I found these by running pg_dump under
"valgrind --leak-check=full". The changes in flagInhIndexes() and
getIndexes() replace allocation of an array of which we use only some elements
by individual allocations of just the actually-needed objects. The previous
coding wasted some memory, but more importantly it confused valgrind's leak
tracking. collectComments() and collectSecLabels() remain major blots on the
valgrind report, because they don't PQclear their query results, in order to
avoid a lot of strdup's. That's a dubious tradeoff, but I'll leave it alone
here; an upcoming patch will modify those functions enough to justify changing
the tradeoff.
[https://git.postgresql.org/pg/commitdiff/70bef494000e4dbbeca0f0a40347ca1747aea701](https://git.postgresql.org/pg/commitdiff/70bef494000e4dbbeca0f0a40347ca1747aea701)

Andres Freund pushed:

- Adapt src/test/ldap/t/001_auth.pl to work with openldap 2.5. ldapsearch's
deprecated -h/-p arguments were removed, need to use -H now - which has been
around for over 20 years. As perltidy insists on reflowing the parameters
anyway, change order and "phrasing" to yield a less confusing layout (per
suggestion from Tom Lane). Discussion:
[https://postgr.es/m/20211009233850.wvr6apcrw2ai6cnj@alap3.anarazel.de](https://postgr.es/m/20211009233850.wvr6apcrw2ai6cnj@alap3.anarazel.de)
Backpatch: 11-, where the tests were added.
[https://git.postgresql.org/pg/commitdiff/984f460e2f29e7ba9174cabb9f43a0d1dce543bf](https://git.postgresql.org/pg/commitdiff/984f460e2f29e7ba9174cabb9f43a0d1dce543bf)

Amit Kapila pushed:

- Remove unused wait events. Commit 464824323e introduced the wait events which
were neither used by that commit nor by follow-up commits for that work.
Author: Masahiro Ikeda Backpatch-through: 14, where it was introduced
Discussion:
[https://postgr.es/m/ff077840-3ab2-04dd-bbe4-4f5dfd2ad481@oss.nttdata.com](https://postgr.es/m/ff077840-3ab2-04dd-bbe4-4f5dfd2ad481@oss.nttdata.com)
[https://git.postgresql.org/pg/commitdiff/1607cd0b6c9919bf765198882ea48a98e901e1bc](https://git.postgresql.org/pg/commitdiff/1607cd0b6c9919bf765198882ea48a98e901e1bc)

Andrew Dunstan pushed:

- Add module build directory to the PATH for TAP tests. For non-MSVC builds this
is make's $(CURDIR), while for MSVC builds it is $topdir/$Config/$module. The
directory is added as the second element in the PATH, so that the install
location takes precedence, but the added PATH element takes precedence over
the rest of the PATH. The reason for this is to allow tests to find built
products that are not installed, such as the libpq_pipeline test driver. The
libpq_pipeline test is adjusted to take advantage of this. Based on a
suggestion from Andres Freund. Backpatch to release 14. Discussion:
[https://postgr.es/m/4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net](https://postgr.es/m/4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net)
[https://git.postgresql.org/pg/commitdiff/f4ce6c4d3a30ec3a12c7f64b90a6fc82887ddd7b](https://git.postgresql.org/pg/commitdiff/f4ce6c4d3a30ec3a12c7f64b90a6fc82887ddd7b)

- Move Perl test modules to a better namespace. The five modules in our TAP test
framework all had names in the top level namespace. This is unwise because,
even though we're not exporting them to CPAN, the names can leak, for example
if they are exported by the RPM build process. We therefore move the modules
to the PostgreSQL::Test namespace. In the process PostgresNode is renamed to
Cluster, and TestLib is renamed to Utils. PostgresVersion becomes simply
PostgreSQL::Version, to avoid possible confusion about what it's the version
of. Discussion:
[https://postgr.es/m/aede93a4-7d92-ef26-398f-5094944c2504@dunslane.net](https://postgr.es/m/aede93a4-7d92-ef26-398f-5094944c2504@dunslane.net)
Reviewed by Erik Rijkers and Michael Paquier
[https://git.postgresql.org/pg/commitdiff/b3b4d8e68ae83f432f43f035c7eb481ef93e1583](https://git.postgresql.org/pg/commitdiff/b3b4d8e68ae83f432f43f035c7eb481ef93e1583)

Noah Misch pushed:

- Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY. CIC and
REINDEX CONCURRENTLY assume backends see their catalog changes no later than
each backend's next transaction start. That failed to hold when a backend
absorbed a relevant invalidation in the middle of running RelationBuildDesc()
on the CIC index. Queries that use the resulting index can silently fail to
find rows. Fix this for future index builds by making RelationBuildDesc()
loop until it finishes without accepting a relevant invalidation. It may be
necessary to reindex to recover from past occurrences; REINDEX CONCURRENTLY
suffices. Back-patch to 9.6 (all supported versions). Noah Misch and Andrey
Borodin, reviewed (in earlier versions) by Andres Freund. Discussion:
[https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com](https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com)
[https://git.postgresql.org/pg/commitdiff/fdd965d074d46765c295223b119ca437dbcac973](https://git.postgresql.org/pg/commitdiff/fdd965d074d46765c295223b119ca437dbcac973)

- Fix CREATE INDEX CONCURRENTLY for the newest prepared transactions. The
purpose of commit 8a54e12a38d1545d249f1402f66c8cde2837d97c was to fix this,
and it sufficed when the PREPARE TRANSACTION completed before the CIC looked
for lock conflicts. Otherwise, things still broke. As before, in a cluster
having used CIC while having enabled prepared transactions, queries that use
the resulting index can silently fail to find rows. It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices. Fix
this for future index builds by making CIC wait for arbitrarily-recent
prepared transactions and for ordinary transactions that may yet PREPARE
TRANSACTION. As part of that, have PREPARE TRANSACTION transfer locks to its
dummy PGPROC before it calls ProcArrayClearTransaction(). Back-patch to 9.6
(all supported versions). Andrey Borodin, reviewed (in earlier versions) by
Andres Freund. Discussion:
[https://postgr.es/m/01824242-AA92-4FE9-9BA7-AEBAFFEA3D0C@yandex-team.ru](https://postgr.es/m/01824242-AA92-4FE9-9BA7-AEBAFFEA3D0C@yandex-team.ru)
[https://git.postgresql.org/pg/commitdiff/3cd9c3b921977272e6650a5efbeade4203c4bca2](https://git.postgresql.org/pg/commitdiff/3cd9c3b921977272e6650a5efbeade4203c4bca2)