"Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
>>>> which are executed without having bothered to check for aborted state.
>>>> I think this code should be removed from postgres.c, and the
>>>> SetQuerySnapshot call instead made from the Fetch and Copy arms of the
>>>> switch statement in ProcessUtility() (utility.c), after doing
>>>> CHECK_IF_ABORTED in each case.
> Is it bad to check ABORTED after yyparse() in parser.c ?
Yes. Try to execute an END (a/k/a ABORT, ROLLBACK, ...)
The check for abort state has to happen in the appropriate paths of
execution, not in the parser. Not all statements should reject on
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Adriaan Joubert||Date: 2000-04-05 05:31:33|
|Subject: Re: 7.0 FK trigger question|
|Previous:||From: Hiroshi Inoue||Date: 2000-04-05 04:02:06|
|Subject: RE: postgres crash on CURSORS|