Skip site navigation (1) Skip section navigation (2)

Re: postgres crash on CURSORS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp>
Cc: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres crash on CURSORS
Date: 2000-04-05 04:04:07
Message-ID: 16330.954907447@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
"Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> writes:
>>>> which are executed without having bothered to check for aborted state.
>>>> I think this code should be removed from postgres.c, and the
>>>> SetQuerySnapshot call instead made from the Fetch and Copy arms of the
>>>> switch statement in ProcessUtility() (utility.c), after doing
>>>> CHECK_IF_ABORTED in each case.

> Is it bad to check ABORTED after yyparse() in parser.c ?

Yes.  Try to execute an END (a/k/a ABORT, ROLLBACK, ...)

The check for abort state has to happen in the appropriate paths of
execution, not in the parser.  Not all statements should reject on
abort state.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Adriaan JoubertDate: 2000-04-05 05:31:33
Subject: Re: 7.0 FK trigger question
Previous:From: Hiroshi InoueDate: 2000-04-05 04:02:06
Subject: RE: postgres crash on CURSORS

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group