Skip site navigation (1) Skip section navigation (2)

Re: column ordering, was Re: [PATCHES] Enums patch v2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Gregory Stark <stark(at)enterprisedb(dot)com>
Subject: Re: column ordering, was Re: [PATCHES] Enums patch v2
Date: 2006-12-20 03:44:53
Message-ID: 16297.1166586293@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> On Tuesday 19 December 2006 11:25, Martijn van Oosterhout wrote:
>> A patch to allow seperate physical and logical orderings was submitted
>> and rejected. Unless something has changed on that front, any
>> discussion in this direction isn't really useful.

> The patch was rejected on technical means, and the author decided it was too 
> much work to finish it.  If someone wanted to try and complete that work I 
> don't think anyone would stand against it. 

Apparently you don't remember the discussion.  The fundamental objection
to it was that it would create a never-ending source of bugs, ie, using
the logical column number where the physical number was required or vice
versa.  Even assuming that we could eliminate all such bugs in the code
base at any instant, what would prevent introduction of another such bug
in every patch?  Most ordinary test cases would fail to expose the
difference.

If you can show me a reasonably bulletproof or machine-checkable way to
keep the two kinds of column numbers distinct, I'd be all for it.  But
without that, the answer will remain no.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2006-12-20 03:54:26
Subject: Re: Companies Contributing to Open Source
Previous:From: Alvaro HerreraDate: 2006-12-20 03:43:11
Subject: Re: Autovacuum Improvements

pgsql-patches by date

Next:From: Takayuki TsunakawaDate: 2006-12-20 04:06:37
Subject: Re: Load distributed checkpoint
Previous:From: Robert TreatDate: 2006-12-20 03:35:21
Subject: Re: column ordering, was Re: [PATCHES] Enums patch v2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group