Skip site navigation (1) Skip section navigation (2)

Re: Review: listagg aggregate

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, "pgsql-hackers(at)postgresql(dot)org Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: listagg aggregate
Date: 2010-02-01 05:07:52
Message-ID: 162867791001312107le140d91wbe1cf29669ef76da@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/2/1 Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>:
>
> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> > ok - I am only one who like original behave - so I ?am withdrawing.
>> > Robert, If you like, please commit Itagaki's patch. + add note about
>> > behave when second parameter isn't stable.
>>
>> I haven't even looked at this code - I sort of assumed Itagaki was
>> handling this one.  But it might be good to make sure that the docs
>> have been read through by a native English speaker prior to commit...
>
> Applied with some editorialization. Please check the docs are good enough.
>
> I removed a test pattern for variable delimiters from regression test
> because it might be an undefined behavior. We might change the behavior
> in the future, so we guarantee only constant delimiters.
>
> The transition functions are renamed to "string_agg_transfn" and
> "string_agg_delim_transfn". We cannot use "string_agg_transfn" for
> both names because we cast the function name as regproc in bootstrap;
> it complains about duplicated function names.

thank you very much

Pavel Stehule

>
> Regards,
> ---
> Takahiro Itagaki
> NTT Open Source Software Center
>
>
>

In response to

Responses

pgsql-hackers by date

Next:From: Takahiro ItagakiDate: 2010-02-01 05:19:16
Subject: Re: Largeobject Access Controls (r2460)
Previous:From: Bruce MomjianDate: 2010-02-01 03:58:47
Subject: Re: Hot Standby and VACUUM FULL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group