Skip site navigation (1) Skip section navigation (2)

Re: Review: listagg aggregate

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, "David E(dot) Wheeler" <david(at)kineticode(dot)com>, "pgsql-hackers(at)postgresql(dot)org Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: listagg aggregate
Date: 2010-01-28 17:14:37
Message-ID: 162867791001280914h5394ac18rdeb311ad3f2f44dc@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/1/28 Robert Haas <robertmhaas(at)gmail(dot)com>:
> On Wed, Jan 27, 2010 at 9:47 PM, Takahiro Itagaki
> <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>> * Do we need better names for string_agg1_transfn and string_agg2_transfn?
>>  They are almost "internal names", but we could have more
>>  like string_agg_with_sep_transfn.
>
> Surely the names of the transition and final functions should match
> the name of the aggregate.  But if there's a proposal on the table to
> call this string_app_with_sep() instead of just string_agg(), +1 from
> me.

no, >>>string_app_with_sep<<< is too long for common using.

Pavel

>
> ...Robert
>

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-01-28 17:16:59
Subject: Re: Review: listagg aggregate
Previous:From: Tom LaneDate: 2010-01-28 17:12:58
Subject: Re: Add on_trusted_init and on_untrusted_init to plperl [PATCH]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group