Re: plpgsql: open for execute - add USING clause

2010/1/14 Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>:
>
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
>> ok, I accept all comments.
>> revised version are attached.
>
> Good. This patch is ready to commit. I'll do it soon if no objections.
>
> BTW, I found inconsistent parameter dumps in the codes. Some of them
> add '$', but others does not. Are they intentional? Or, should we
> adjust them to use one of the formats?
>
> [pl_funcs.c]
> dump_dynexecute()
> dump_raise()
>                        printf("    parameter %d: ", i++);
> dump_dynfors()
> dump_open()
> dump_return_query()
>                        printf("    parameter $%d: ", i++);
>

isn't parameter of raise statement different than query parameter?

I thing so $x convention respects parameter holder syntax.

Regards
Pavel

>
> Regards,
> ---
> Takahiro Itagaki
> NTT Open Source Software Center
>
>
>