Re: WIP: to_char, support for EEEE format

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: to_char, support for EEEE format
Date: 2009-04-26 04:24:55
Message-ID: 162867790904252124j2b0c17cer50f019e0ed6d3a4c@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Brendan

this looks well, so please, add it to commitfest page

regards
Pavel Stehule

2009/4/26 Brendan Jurd <direvus(at)gmail(dot)com>:
> On Sat, Apr 11, 2009 at 3:51 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> So, please, if you can, propose these error messages (with hints)-
>> result will be much better.
>>
>
> Hi Pavel, hackers.
>
> I've done some work updating Pavel's sci notation patch for to_char().
>  I've attached a patch against HEAD (EEEE_2.diff.bz2) and against
> Pavel's patch as originally submitted to the list
> (EEEE_1-to-2.diff.bz2).
>
> A summary of my changes:
>
>  * Improve the wording of error messages, and add some detail/hint parts.
>  * Update the documentation.
>  * Move the duplicated "one digit before decimal point" test into a macro.
>  * Fix a bug in the int8_to_char() implementation (was using the wrong
> variable).
>
> Hope you find this useful.
>
> Cheers,
> BJ
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message tomas 2009-04-26 06:05:27 Re: RFE: Transparent encryption on all fields
Previous Message Robert Haas 2009-04-26 04:14:29 Re: HashJoin w/option to unique-ify inner rel