2008/11/30 Peter Eisentraut <peter_e(at)gmx(dot)net>:
> On Thursday 27 November 2008 00:14:19 Pavel Stehule wrote:
>> I am sending actualized versions - I accepted Tom's comments - default
>> expressions are serialised List stored in text field.
> OK, this is looking pretty good.
> There is a structural problem that we need to address. With your patch,
> pg_dump produces something like this:
> CREATE FUNCTION foo(a integer = 1, b integer = 2, c integer = 3) RETURNS
> LANGUAGE sql
> AS $_$ SELECT $1 + $2 + $3; $_$;
> ALTER FUNCTION public.foo(a integer = 1, b integer = 2, c integer = 3) OWNER
> TO peter;
> The second command is rejected because default values are only accepted in
> CREATE FUNCTION.
> There are two ways to fix this, both having some validity:
> 1. We create a second version of pg_get_function_arguments() that produces
> arguments without default values decoration. This is probably the
> technically sound thing to do.
> 2. We accept the default values specification and ignore it silently. Note
> that we already silently ignore the argument names. ALTER FUNCTION foo(a
> int, b int) will also act on a function defined as foo(x int, y int).
if this variant is possible, then will be simply implemented
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2008-11-30 17:49:31|
|Subject: Re: WIP: default values for function parameters |
|Previous:||From: Peter Eisentraut||Date: 2008-11-30 15:48:42|
|Subject: Re: WIP: default values for function parameters|