Skip site navigation (1) Skip section navigation (2)

Re: review: table function support

From: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: review: table function support
Date: 2008-07-10 13:38:37
Message-ID: 162867790807100638n47c00eb4w304473a247a20aa7@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
2008/7/10 Marko Kreen <markokr(at)gmail(dot)com>:
> On 7/10/08, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>>  I am sending actualized patch
>>
>>  Regards
>>  Pavel Stehule
>>
>>  2008/7/9 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>:
>>
>> > 2008/7/9 Marko Kreen <markokr(at)gmail(dot)com>:
>>  >> Generally, the patch looks fine.  There are few issues still:
>>  >>
>>  >> - plpgsql: the result columns _do_ create local variables.
>>  >>  AIUI, they should not?
>>  >
>>  > it was my mistake - it doesn't do local variables - fixed
>>  >>
>>  >> - pg_dump: is the psql_assert() introduction necessary, considering it
>>  >>  is used only in one place?
>>  >
>>  > removed - argmode variables is checked before
>>  >>
>>  >> - There should be regression test for plpgsql too, that test if
>>  >>  the behaviour is correct.
>>  >>
>>  >
>>  > addeded
>>  >> - The documentation should mention behaviour difference from OUT
>>  >>  parameters.
>>  >
>>  > I will do it.
>>  >>
>>  >> Wishlist (probably out of scope for this patch):
>>  >
>>  > this is in my wishlist too, but postgresql doesn't support types like
>>  > result of functions.
>>  >>
>>  >> - plpgsql: a way to create record variable for result row.  Something like:
>>  >>
>>  >>    CREATE FUNCTION foo(..) RETURNS TABLE (..) AS $$
>>  >>    DECLARE
>>  >>       retval   foo%ROWTYPE;
>>  >>
>>  >>
>>  >>  Currently the OUT parameters are quite painful to use due to bad
>>  >>  name resolving logic.  Such feature would be perfect replacement.
>>  >>
>>  >> --
>>  >> marko
>>  >>
>>  > I'll send patch early, thank you much
>
> Ok, last items:
>
> - Attached is a patch that fixes couple C comments.
>
> - I think plpgsql 38.1.2 chapter of "Supported Argument and Result Data
>  Types" should also have a mention of TABLE functions.
>
> Then I'm content with the patch.
>
applyed

Regards and thank you very much

Pavel

> --
> marko
>

Attachment: tabfce1.2.diff
Description: text/x-patch (25.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-07-10 14:16:48
Subject: Re: CommitFest rules
Previous:From: Peter EisentrautDate: 2008-07-10 12:56:13
Subject: Re: CREATE CAST too strict?

pgsql-patches by date

Next:From: David FetterDate: 2008-07-10 14:18:28
Subject: Re: WITH RECURSIVE updated to CVS TIP
Previous:From: Marko KreenDate: 2008-07-10 12:10:39
Subject: Re: review: table function support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group