Skip site navigation (1) Skip section navigation (2)

Re: pg_regress: paths in largeobject test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Jorgen Austvik - Sun Norway <Jorgen(dot)Austvik(at)Sun(dot)COM>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_regress: paths in largeobject test
Date: 2007-11-30 14:53:20
Message-ID: 1628.1196434400@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Jorgen Austvik - Sun Norway wrote:
>> Tom Lane wrote:
>>> I'd put it the other way around: likely we should get rid of the
>>> one use of @abs_builddir(at)(dot)
>>
>> Generally I prefer explicit over implicit (having the full paths make 
>> troubleshooting easier), but in this case you have the additional aspect of 
>> the lo_import operating relative to the client, while lo_export operates 
>> relative to the server.

> I submit that the test is OK as it currently is.

Yeah, I hadn't thought about the different-paths aspect at the time of
making the above comment; but given that, it is correct as-is.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-11-30 20:22:07
Subject: Re: [HACKERS] [GENERAL] plperl and regexps with accented characters - incompatible?
Previous:From: Alvaro HerreraDate: 2007-11-30 12:21:17
Subject: Re: pg_regress: paths in largeobject test

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group