Skip site navigation (1) Skip section navigation (2)

Re: Windowing Function Patch Review -> Standard Conformance

From: "David Rowley" <dgrowley(at)gmail(dot)com>
To: "'Hitoshi Harada'" <umi(dot)tanuki(at)gmail(dot)com>
Cc: <heikki(dot)linnakangas(at)enterprisedb(dot)com>,<pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Windowing Function Patch Review -> Standard Conformance
Date: 2008-11-27 19:15:26
Message-ID: 161E23BEA0FE44C58E7819E362CC093E@amd64 (view raw or flat)
Thread:
Lists: pgsql-hackers
I wrote:
> > Hmm, did you apply the latest patch correctly? My build can produce
> > right results, so I don't see why it isn't fixed. Make sure the lines
> > around 2420-2430 in planner.c like:
> >                        /*
> >                         * must copyObject() to avoid args concatenating
> with each other.
> >                         */
> >                        pulled_exprs = list_concat(pulled_exprs,
> copyObject(wfunc->args));
> >
> > where copyObject() is added.
> 
> I'm sitting here away from home with a funny feeling I forgot to make
> install.
> I think my home adsl has dropped out so can't confirm that. If it
> works for you and not for me last night then I probably did forget.
> 
> I'll let you know.

Sorry, false alarm. What can I say, it was late. I did make install, just to
the wrong place, so ended up using the old binary.

Sorry for panic. The bug is fixed. Only I still get regression failures on
window. Do they all pass for you?

I have most of the weekend to test Heikki's work, in fact it's building now.
But I'll have to leave it running...

David.





In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2008-11-27 19:29:15
Subject: Re: New trigger file in pg_standby to promote thestandby to the primary
Previous:From: Simon RiggsDate: 2008-11-27 17:14:37
Subject: Re: Review: Hot standby

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group