Skip site navigation (1) Skip section navigation (2)

Clearing psql's input buffer after auto-reconnect

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Clearing psql's input buffer after auto-reconnect
Date: 2010-05-25 02:30:06
Message-ID: 16137.1274754606@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
We determined that $SUBJECT would be a good idea in this thread:
http://archives.postgresql.org/pgsql-bugs/2010-05/msg00159.php

I looked a bit at what it would take to make this happen.  The
difficulty is that the input buffer is a local variable in MainLoop(),
and so are a bunch of other subsidiary variables that would need to be
reset along with it.  The place where auto-reconnect presently happens
is CheckConnection(), which is in a different file and is also several
levels of subroutine call away from MainLoop.  AFAICS there are three
ways that we might attack this:

1. Massive restructuring of the code in common.c so that the fact of
a connection reset having happened can be returned back to MainLoop.

2. Export much of MainLoop's internal state as globals, so that
CheckConnection can hack on it directly.

3. Have CheckConnection do longjmp(sigint_interrupt_jmp) after resetting
the connection, to force control to go back to MainLoop directly.
MainLoop is already coded to clear its local state after catching a
longjmp.

Now #1 might be the best long-term solution but I have no particular
appetite to tackle it, and #2 is just too ugly to contemplate.  That
leaves #3, which is a bit ugly in its own right but seems like the best
fix we're likely to get.

Comments, better ideas?

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2010-05-25 02:46:50
Subject: Re: Synchronization levels in SR
Previous:From: Josh BerkusDate: 2010-05-25 01:29:31
Subject: Re: Synchronization levels in SR

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group