Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Point in Time Recovery

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgman(at)candle(dot)pha(dot)pa(dot)us, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Point in Time Recovery
Date: 2004-07-17 18:53:46
Message-ID: 16031.1090090426@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-adminpgsql-hackerspgsql-patches
[ ... some desultory reading of PITR patch ... ]

What is the point of having both archive_program and archive_dest as
GUC variables?  Wouldn't it be simpler to fold them into one parameter,
viz

	archive_command = 'cp %s /archivedir'

For that matter, do we need a separate archive_mode boolean?  The one
thing I can positively guarantee about archive_dest (or archive_command)
is that we cannot come up with a useful default for it (no, /tmp isn't
good).  Therefore it does not seem very reasonable to let the user turn
on archiving without having explicitly specified an archive destination.

I propose that we fold all three GUC flags into a single archive_command
string whose built-in default is an empty string, and you enable
archiving by setting it to something nonempty.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2004-07-17 19:08:43
Subject: Re: [HACKERS] Point in Time Recovery
Previous:From: Peter EisentrautDate: 2004-07-17 16:55:40
Subject: Re: Documentation on new features?

pgsql-admin by date

Next:From: Bruce MomjianDate: 2004-07-17 19:08:43
Subject: Re: [HACKERS] Point in Time Recovery
Previous:From: Joost KraaijeveldDate: 2004-07-17 18:50:48
Subject: Re: Logging PostgreSQL output

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-07-17 19:08:43
Subject: Re: [HACKERS] Point in Time Recovery
Previous:From: Tom LaneDate: 2004-07-17 16:36:10
Subject: Re: doc/src/sgml/ref/create_database.sgml had an extra <para> tag

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group