Skip site navigation (1) Skip section navigation (2)

Re: heap_tuple_needs_freeze false positive

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: heap_tuple_needs_freeze false positive
Date: 2012-02-02 04:03:46
Message-ID: 15676.1328155426@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> ! 	if (!(tuple->t_infomask & HEAP_XMAX_INVALID))
>   	{
> ! 		if (!(tuple->t_infomask & HEAP_XMAX_IS_MULTI))

How about just one test,

	if (!(tuple->t_infomask & (HEAP_XMAX_INVALID | HEAP_XMAX_IS_MULTI)))

But other than that quibble, yeah, it's a bug.  XMAX_INVALID means just
that: the xmax is not to be thought valid.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2012-02-02 04:33:13
Subject: freezing multixacts
Previous:From: Tom LaneDate: 2012-02-02 03:57:48
Subject: Re: spgist text_ops and LIKE

Privacy Policy | About PostgreSQL
Copyright © 1996-2013 The PostgreSQL Global Development Group