Re: heap_tuple_needs_freeze false positive

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: heap_tuple_needs_freeze false positive
Date: 2012-02-02 04:03:46
Message-ID: 15676.1328155426@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> ! if (!(tuple->t_infomask & HEAP_XMAX_INVALID))
> {
> ! if (!(tuple->t_infomask & HEAP_XMAX_IS_MULTI))

How about just one test,

if (!(tuple->t_infomask & (HEAP_XMAX_INVALID | HEAP_XMAX_IS_MULTI)))

But other than that quibble, yeah, it's a bug. XMAX_INVALID means just
that: the xmax is not to be thought valid.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-02-02 04:33:13 freezing multixacts
Previous Message Tom Lane 2012-02-02 03:57:48 Re: spgist text_ops and LIKE