Skip site navigation (1) Skip section navigation (2)

Re: pgcrypto: Makefile check

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pgcrypto: Makefile check
Date: 2004-11-22 15:46:21
Message-ID: 15633.1101138381@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> This patch makes the pgcrypto Makefile check that a recognized random
> source has been defined. If no such source is defined, pgcrypto will
> compile successfully but will be unusable.

Oh?

> +$(error "Unrecognized random source: $(random)")

Doesn't look like a successful compile to me.  What's worse, this would
also cause maintenance operations (like "make clean") to fail.

(I see little point in this anyway given that the makefile defaults to
"random = silly" further up.)

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Michael FuhrDate: 2004-11-22 16:36:55
Subject: Re: another plperl bug
Previous:From: Andrew DunstanDate: 2004-11-22 12:37:46
Subject: another plperl bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group