Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> You seem to have entirely missed the point of Alvaro's remark, which is
>> that you've got xlog.h including walsender.h (still) as well as
>> walsender.h including xlog.h. That's broken.
> Oh, OK, done. xlog.h removed from walsender.h and tested.
I would have gone the other way on that one, if possible. Seems like
xlog.h ought to be the lower-level file.
Some quick mechanical analysis shows that's not the only circular
inclusion path in our headers, either: we have storage/proc.h including
replication/syncrep.h which includes storage/proc.h. That one appears
to be Simon's fault not yours though.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Satoshi Nagayasu||Date: 2011-09-04 03:56:15|
|Subject: xlogdump 0.4.0|
|Previous:||From: Bruce Momjian||Date: 2011-09-04 01:25:17|
|Subject: Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include
in cube contrib --- caused crash on a Ge|
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2011-09-04 02:19:44|
|Subject: pgsql: Remove unnecessary and circular #include.|
|Previous:||From: Bruce Momjian||Date: 2011-09-04 01:25:40|
|Subject: pgsql: walsender.h doesn't need xlog.h, per Tom.|