Re: pgsql: Add time/date macros for code clarity: #define DAYS_PER_YEAR

BTW, the initial returns (see kookaburra buildfarm log) say that you
broke things completely.

cc -O2 -qmaxmem=16384 -qsrcmsg -qlonglong -g -I../../../../src/include -I/usr/local/include -c -o timestamp.o timestamp.c
1211 | span->time = (((((tm->tm_hour * ((int64) SECS_PER_MINUTELL)) +
.................................................a....................
a - 1506-045 (S) Undeclared identifier SECS_PER_MINUTELL.
1611 | span1 += interval1->month * ((int64) DAYS_PER_MONTHLL) * ((int64) 86400000000LL);
.............................................a..................................
a - 1506-045 (S) Undeclared identifier DAYS_PER_MONTHLL.
1612 | span1 += interval1->day * ((int64) HOURS_PER_DAYLL) * ((int64) 3600000000LL);
...........................................a....................................
a - 1506-045 (S) Undeclared identifier HOURS_PER_DAYLL.
2267 | result->time += (months - result->month) * ((int64) DAYS_PER_MONTHLL) * ((int64) 86400000000LL);
............................................................a...................
a - 1506-045 (S) Undeclared identifier DAYS_PER_MONTHLL.
2268 | result->time += (days - result->day) * ((int64) HOURS_PER_DAYLL) * ((int64) 3600000000LL);
........................................................a.......................
a - 1506-045 (S) Undeclared identifier HOURS_PER_DAYLL.
gmake[4]: *** [timestamp.o] Error 1

regards, tom lane