| From: | Lee Kindness <lkindness(at)csl(dot)co(dot)uk> |
|---|---|
| To: | Bill Studenmund <wrstuden(at)netbsd(dot)org> |
| Cc: | Lee Kindness <lkindness(at)csl(dot)co(dot)uk>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org> |
| Subject: | Re: ecpg - GRANT bug |
| Date: | 2001-10-17 09:00:31 |
| Message-ID: | 15309.18607.881835.681681@elsick.csl.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Bill Studenmund writes:
> I think this patch is wrong. Wouldn't it be better to make the line number
> in yylineno be correct? Also, there are users of the line number in pcg.l
> which you didn't change.
> Looking at it, I don't see why the line number is off. It is initialized
> to 1 at the begining and whenever a new file is included. In the generated
> code, it is incrimented whenever a '\n' is found. Strange...
The main reason I split the patch from the previous one for ecpg was
for this reason - I didn't think it was the correct patch myself.
However after a serious hunt for the root of the problem I've found
that it is actually working correctly in the 7.2 sources and I was
picking up an ecpg from a 7.1.3ish build (which only contained an ecpg
binary). Appologies for the false hunt!
For the record it was fixed in pgc.l 1.79 (meskes 13-Jun-01).
Regards, Lee.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephan Szabo | 2001-10-17 12:12:54 | Re: Bug #485: strange behavior when creting rules with |
| Previous Message | pgsql-bugs | 2001-10-17 05:19:46 | Bug #485: strange behavior when creting rules with serial id |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron de Jong | 2001-10-17 11:45:22 | How do I get a list of DB's or Tables with a postgres SQL statement? |
| Previous Message | Lee Kindness | 2001-10-17 08:36:35 | Re: Column names - time |