Skip site navigation (1) Skip section navigation (2)

Re: More fixes for missing double quotes in the shell scripts

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Justin <justin(at)postgresql(dot)org>
Cc: PostgreSQL Patches Mailing List <pgsql-patches(at)postgresql(dot)org>
Subject: Re: More fixes for missing double quotes in the shell scripts
Date: 2001-09-27 03:43:14
Message-ID: 15260.1001562194@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Justin <justin(at)postgresql(dot)org> writes:
> If there's really something fundamentally wrong with this idea, then
> let's only do the necessary ones.

No, nothing fundamentally wrong.  I just prefer to avoid unnecessary
notational clutter.  Your approach of "let's quote *every* shell
variable" is defensible but I find it a tad over-the-top.  Comes down
to a judgment call about code legibility, I suppose.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: JustinDate: 2001-09-27 03:44:58
Subject: Re: More fixes for missing double quotes in the shell scripts
Previous:From: JustinDate: 2001-09-27 03:09:41
Subject: Re: More fixes for missing double quotes in the shell scripts

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group