Skip site navigation (1) Skip section navigation (2)

Re: BUG #6704: ALTER EXTENSION postgis SET SCHEMA leaves dangling relations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, jeff <jeff(at)pgexperts(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6704: ALTER EXTENSION postgis SET SCHEMA leaves dangling relations
Date: 2012-09-24 02:36:00
Message-ID: 15238.1348454160@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
> Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
>> I think we shouldn't change the content of pg_depend lightly here, and

> So here's a patch following that idea.

I've got to say that I think this is fundamentally the wrong approach:
rather than fixing the generic problem of ALTER EXTENSION not coping
with multiple dependency paths to the same object, it hacks the specific
case of owned sequences, and what's more it does that by assuming that
every owned sequence *will* have a dependency on the extension.  That's
not a safe assumption.

Still, this might be the best approach for the back branches, given that
we do not know of any existing multiple-dependency scenarios other than
the owned-sequence case.  A real fix is looking mighty invasive.

> Even for TIP I don't want us to change how pg_depend tracking is done,

Agreed.  Quite aside from backwards-compatibility concerns, I think that
trying to avoid multiple dependency paths is doomed to failure.

			regards, tom lane


In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2012-09-24 03:04:20
Subject: Re: BUG #6704: ALTER EXTENSION postgis SET SCHEMA leaves dangling relations
Previous:From: Reinhard MaxDate: 2012-09-21 19:31:25
Subject: Re: BUG #7559: syslogger doesn't close stdout and stderr

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group