| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Infrastructure changes for recovery |
| Date: | 2009-01-27 15:37:53 |
| Message-ID: | 15190.1233070673@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> (replying to a very old message, since I just bumped into this in review)
> Alvaro Herrera wrote:
>> The new message is not translatable, the original was.
> Doesn't really matter since it's an elog(), not ereport().
... which is wrong in itself, since it's certainly meant as a
user-facing (or at least DBA-facing) message. elog should generally
only be used for debugging or "can't happen" messages, not for stuff
that users are expected to see on a routine basis.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2009-01-27 15:37:58 | Re: mingw check hung |
| Previous Message | Joshua D. Drake | 2009-01-27 15:35:39 | Re: 8.4 release planning |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-02-03 01:38:11 | Re: [PATCHES] GIN improvements |
| Previous Message | Heikki Linnakangas | 2009-01-27 14:09:51 | Re: [PATCHES] Infrastructure changes for recovery |