Skip site navigation (1) Skip section navigation (2)

Re: Caution when removing git branches

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Caution when removing git branches
Date: 2011-01-27 16:29:24
Message-ID: 15182.1296145764@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Wed, Jan 26, 2011 at 17:37, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> I thought we had some hooks on gitmaster to help prevent accidents like
>> inadvertent branch deletion.

> We have hooks to prevent a number of things, but not the removal of
> branches (or tags). We'll send an email to committers telling you it's
> been done, but we don't prevent it.

> It would probably be pretty easy to add a hook preventing it though -
> do we want that? (we could still delete branches of course - but it
> would require an admin to do it directly on the git server, which is
> highly unlikely to happen by mistake)

Given that nobody is supposed to push temporary branches to the master
repo anyway, an intended branch removal should be a pretty darn rare
event.  Now, our committers all seem to be pretty careful people, so
I don't feel strongly about having extra security on this --- but if
it's easy to do, it's probably a good idea.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2011-01-27 16:33:55
Subject: Re: Re: In pg_test_fsync, use K(1024) rather than k(1000) for write size units.
Previous:From: Robert HaasDate: 2011-01-27 16:25:19
Subject: Re: Caution when removing git branches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group